Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subprocesses cleanup breaks too easily #586

Closed
ark3 opened this issue Apr 11, 2018 · 2 comments
Closed

Subprocesses cleanup breaks too easily #586

ark3 opened this issue Apr 11, 2018 · 2 comments
Assignees
Labels
bug
Projects

Comments

@ark3
Copy link
Contributor

@ark3 ark3 commented Apr 11, 2018

This happens sometimes in test_disconnect.

Traceback (most recent call last):
  File "/home/circleci/project/telepresence/cli.py", line 74, in call_f
    return f(*args, **kwargs)
  File "/home/circleci/project/telepresence/main.py", line 507, in go_too
    runner, remote_info, args, env, subprocesses, socks_port, ssh
  File "/home/circleci/project/telepresence/local.py", line 166, in run_local_command
    wait_for_exit(runner, p, subprocesses)
  File "/home/circleci/project/telepresence/cleanup.py", line 84, in wait_for_exit
    dead_process = processes.any_dead()
  File "/home/circleci/project/telepresence/cleanup.py", line 60, in any_dead
    self.killall()
  File "/home/circleci/project/telepresence/cleanup.py", line 46, in killall
    killer()
  File "/home/circleci/project/telepresence/cleanup.py", line 38, in kill
    kill_process(process)
  File "/home/circleci/project/telepresence/cleanup.py", line 13, in kill_process
    process.terminate()
  File "/opt/circleci/.pyenv/versions/3.5.2/lib/python3.5/subprocess.py", line 1782, in terminate
    self.send_signal(signal.SIGTERM)
  File "/opt/circleci/.pyenv/versions/3.5.2/lib/python3.5/subprocess.py", line 1777, in send_signal
    os.kill(self.pid, sig)
ProcessLookupError: [Errno 3] No such process
@ark3 ark3 added the bug label Apr 11, 2018
@ark3 ark3 self-assigned this Apr 11, 2018
@ark3
Copy link
Contributor Author

@ark3 ark3 commented Nov 19, 2018

More generally, any sort of crash during subprocesses cleanup breaks cleanup of the remaining subprocesses.

@ark3 ark3 changed the title Crash during disconnect shutdown Subprocesses cleanup is breaks too easily Nov 19, 2018
@ark3 ark3 added this to To do in Tel Tracker via automation Nov 19, 2018
@ark3 ark3 changed the title Subprocesses cleanup is breaks too easily Subprocesses cleanup breaks too easily Nov 20, 2018
@ark3
Copy link
Contributor Author

@ark3 ark3 commented Dec 5, 2018

Fixed by #853; I botched the commit message.

@ark3 ark3 closed this Dec 5, 2018
Tel Tracker automation moved this from To do to Done Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.