Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sudo docker loses environment variables #672

Closed
ark3 opened this issue Jun 1, 2018 · 1 comment
Closed

sudo docker loses environment variables #672

ark3 opened this issue Jun 1, 2018 · 1 comment
Assignees
Labels
bug

Comments

@ark3
Copy link
Contributor

@ark3 ark3 commented Jun 1, 2018

As noted by @jody-frankowski in #669 (comment):

If you are on Linux and telepresence calls docker with sudo you won't have the environment variables when doing --swap-deployment. I just noticed this and I actually had to patch telepresence to call docker with sudo -E.

@ark3 ark3 added the bug label Jun 1, 2018
@ark3 ark3 self-assigned this Jun 1, 2018
@ark3
Copy link
Contributor Author

@ark3 ark3 commented Jun 1, 2018

Note that this is yet another corner-ish case that Telepresence tries to handle, but the test suite does not cover.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.