New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container method fails if no ports exposed (0.91 and 0.92) #750

Closed
ark3 opened this Issue Aug 22, 2018 · 1 comment

Comments

1 participant
@ark3
Contributor

ark3 commented Aug 22, 2018

because the network container crashes:

   9.7  25 | [INFO  tini (1)] Spawned child process 'python3' with pid '8'
   9.9  25 |    0.0 TEL | Telepresence 0+unknown launched at Wed Aug 22 21:04:45 2018
   9.9  25 |    0.0 TEL |   /usr/bin/entrypoint.py proxy '{"port": 58856, "cidrs": ["10.3.240.0/20", "10.0.17.0/24", "10.0.1.0/24", "10.0.0.0/24", "10.0.2.0/24"], "expose_ports": [], "ip": "198.18.0.254"}'
   9.9  25 |    0.0 TEL | Platform: linux
   9.9  25 |    0.0 TEL | Python 3.6.1 (default, Oct  2 2017, 20:46:59)
   9.9  25 |    0.0 TEL | [GCC 6.3.0]
   9.9  25 |    0.0 TEL | [1] Running: uname -a
   9.9  25 |    0.0   1 | Linux 868d9a9b63da 4.9.93-linuxkit-aufs #1 SMP Wed Jun 6 16:55:56 UTC 2018 x86_64 Linux
   9.9  25 |    0.0 TEL | Everything launched. Waiting to exit...
   9.9  25 |    0.0 TEL | BEGIN SPAN __init__.py:497(wait_for_exit)
  10.0  25 | Traceback (most recent call last):
  10.0  25 |   File "/usr/bin/entrypoint.py", line 121, in <module>
  10.0  25 |     main()
  10.0  25 |   File "/usr/bin/entrypoint.py", line 65, in main
  10.0  25 |     proxy(loads(sys.argv[2]))
  10.0  25 |   File "/usr/bin/entrypoint.py", line 104, in proxy
  10.0  25 |     wait_for_exit(runner, main_process)
  10.0  25 |   File "/usr/lib/python3.6/site-packages/telepresence/runner/__init__.py", line 512, in wait_for_exit
  10.0  25 |     dead_bg = runner.tracked.which_dead()
  10.0  25 | AttributeError: 'NoneType' object has no attribute 'which_dead'
  10.0  25 | [INFO  tini (1)] Main child exited normally (with status '1')

Using --expose causes an additional ssh to be launched, avoiding this issue. This is why the usual tests didn't catch this.

Work around this bug by adding an unused --expose 60000 or whatever to your command.

@ark3 ark3 added the bug label Aug 22, 2018

@ark3 ark3 self-assigned this Aug 22, 2018

@ark3 ark3 added this to To do in Tel Tracker via automation Aug 22, 2018

@ark3

This comment has been minimized.

Contributor

ark3 commented Aug 22, 2018

I hack-patched this on Docker Hub. If you're seeing this crash, try this to fix your local Docker:

docker pull datawire/telepresence-local:0.92

@ark3 ark3 closed this in ba71828 Aug 24, 2018

Tel Tracker automation moved this from To do to Done Aug 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment