New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verbose logging can leak tokens #889

Closed
bartoszmajsak opened this Issue Jan 7, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@bartoszmajsak
Copy link
Contributor

bartoszmajsak commented Jan 7, 2019

When running telepresence --verbose, the log contains output of kubectl config view -o json which has plain text tokens to all the contexts user has stored.

   0.2 TEL | [4] Capturing: kubectl config view -o json
   0.2   4 | {
   0.2   4 |     "kind": "Config",
   0.2   4 |     "apiVersion": "v1",
   0.2   4 |     "preferences": {},
  ....
   0.2   4 |     "users": [
   0.2   4 |         {
   0.2   4 |             "name": "developer/127-0-0-1:8443",
   0.2   4 |             "user": {
   0.2   4 |                 "token": "VzJhhhzpojbWSfrQ8Hh8-2NK9Vt7wAr-OJgPiHDA2rg"
   0.2   4 |             }
   0.2   4 |         },
   0.2   4 |         {
   0.2   4 |             "name": "developer/192-168-42-131:8443",
   0.2   4 |             "user": {
   0.2   4 |                 "token": "FHxaYKsdmnU2hkZ4Ot0Krc-tim59BfiAV73luRpCGmc"
   0.2   4 |             }
   0.2   4 |         },
...

This, when shared e.g. in the gist, can lead to exposing sensitive information which can be easily overlooked.

@ark3 ark3 closed this in #890 Jan 24, 2019

ark3 added a commit that referenced this issue Jan 24, 2019

Merge pull request #890 from bartoszmajsak/token_masking
fix(#889): masks k8s tokens when logging in verbose mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment