New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for deployments using `automountServiceAccountToken: false` #313

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@dhensen

dhensen commented Oct 7, 2017

We are using non default deployments. Meaning that we prevent the default service account to be mounted. This makes /var/run/secrets/kubernetes.io/serviceaccount/namespace unavailable to be used by forwarder.py.

@dhensen

This comment has been minimized.

dhensen commented Oct 7, 2017

Oh build failed. I was hoping I could use your CI, but ofcourse encrypted env vars are not available because this PR comes from an external repo... Can we somehow work around this?

@itamarst

This comment has been minimized.

Contributor

itamarst commented Oct 7, 2017

Someone with commit access will have to merge it into branch in main repo, and then open another PR. So just wait until they're back at work next week (Monday or Tuesday) and they can do that.

@ark3

This comment has been minimized.

Contributor

ark3 commented Oct 11, 2017

Merging #314 instead. Thank you for this PR!

@ark3 ark3 closed this Oct 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment