New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for deployments using `automountServiceAccountToken: false` #314

Merged
merged 4 commits into from Oct 11, 2017

Conversation

Projects
None yet
2 participants
@ark3
Contributor

ark3 commented Oct 7, 2017

This is the main repo version of #313.

@dhensen

This comment has been minimized.

dhensen commented Oct 7, 2017

Thanks, I'm coming back with fixed tests soon.

@dhensen

This comment has been minimized.

dhensen commented Oct 9, 2017

I fixed a test, and ran tests locally. Can this branch be synced with mine? Some tests were already failing before my PR. Thanks!

@dhensen

This comment has been minimized.

dhensen commented Oct 9, 2017

Nice, at least the linux build had success. I'm hoping to get this merged soon because we are doing a telepresence integration and are blocked on this now. Thanks for mirroring my PR 👍

@ark3

This comment has been minimized.

Contributor

ark3 commented Oct 9, 2017

The macOS breakage seems like a configuration issue unrelated to your change. I may end up ignoring that here and fixing it elsewhere. As far as the timeline goes, I'd like to land this and a few other small things, then release in the next day or so, definitely by the middle of the week.

I forgot to say this before: Thanks very much for your PR! Can you tell us about your use case? Telepresence development is driven by users like you.

@dhensen

This comment has been minimized.

dhensen commented Oct 10, 2017

Thanks a lot, looking forward to this being merged. You're welcome, it's awesome that telepresence exists and I'm happy to contribute.

Our use case is that we are developing riddles.io on top of kubernetes. We have built our own tooling to support our workflow, packaging, building images, publishing them etc.

One of the things the tool can do is run a given microservice locally from source or run the container locally. Both options make the microservice run against a k8s cluster environment. Basically it means that we connect to backing directly, such as mysql, rabbitmq, redis, etc. Because we are then connected to rabbitmq, our microservice runs alongside other similar microservices transparently.

This works fine for us, but it requires us to keep local application configuration in sync with that of the cluster environment. Also we have to fake some folder mounts and because in one case we are not running inside a container, we have a different startup script than for each microservice not running locally inside a container. I'm one of two guys who knows this bigger picture at our company, but having to manage all this is taxing on developers. That's why we built our own tool.

Now with telepresence, I can basically cut away all the environment variable injecting and just swap deployment 👍

@ark3 ark3 merged commit 6e7d4df into master Oct 11, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
deploy/netlify Deploy preview ready!
Details

@ark3 ark3 deleted the no-service-account branch Oct 11, 2017

@ark3

This comment has been minimized.

Contributor

ark3 commented Oct 11, 2017

@dhensen Setting aside MacOS Travis issues, I've landed this PR. Thanks for your help! If you send me (ark3@datawire.io) an email with your t-shirt size and shipping address, Datawire would be happy to send you a Telepresence t-shirt.

Based on your use case, you may want to look at Forge too. Updating your running system from source code updates and pushing other changes to your cluster can become easy one-liners with Forge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment