New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge `./build` in to `Makefile` #839

Closed
wants to merge 10 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@LukeShu
Contributor

LukeShu commented Nov 21, 2018

When I'm reading code, I tend to modify it, as part of my learning process. So I usually end up with a stack of commits that I throw away before I make my first purposeful commit.

In this case, I think they're changes that do make for a more positive new-developer experience. So maybe I won't throw them away this time :)

This is what my testbench commit is on top of, but I'm sure it wouldn't be too much trouble to rewrite it on top of master instead of on top of this, if you don't like this change.


Begone with the ./build script, move its functionality in to Makefile. This PR does create a new executable ./tools/license-check for the _license_check() function, instead of trying to rewrite that as a Makefile snippet. Both developing.md and the CircleCI config have been updated to use make instead of ./build

This:

  • Reduces the number of tools/scripts a developer has to learn coming on to the project
  • The targets to make are easier to understand than the flags to ./build; both from the ./build --help/make help documentation, and from reading the source.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment