Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Don't hardcode the kubernetes.default FQDN in local-docker #940
The default search domain for clusters can be changed and
So I propose to not use a FQDN.
Make sure every source file you touch has the standard license header.
Before landing, add a changelog entry as a file
Hey, just to avoid leaving you hanging: The lead Telepresence developer, @ark3, is offline for a while because of an injury, and this is something I think we should get his opinion on before merging.
I suspect the more "correct" thing to do would be to construct the FQDN based on the zone, rather than hard-coding a fixed string. I also suspect that this may cause funny things if/when the DNS support switches over to teleproxy-based DNS, which does some really funny things with the DNS search path.
Thank you for the PR. I think your solution is correct. As
And let's worry about Teleproxy integration later.