Skip to content

Update Figma UI Kits Article #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2022
Merged

Update Figma UI Kits Article #795

merged 1 commit into from
Feb 24, 2022

Conversation

yordan-mitev
Copy link
Contributor

This PR updates the existing Figma UI Kits article:

  • Updates the page structure of the UI kit
  • Updates the images
  • Adds a section about InstaRelinker
  • Updates the UI kit naming

cc @jivanova

@yordan-mitev yordan-mitev requested a review from a team February 23, 2022 07:43
@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2022

Hello @yordan-mitev,

Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.

  • create pr to production

Copy link
Contributor

@dimodi dimodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a special reason to use &mbdash; instead of a plain hyphen?

@yordan-mitev
Copy link
Contributor Author

Is there a special reason to use &mbdash; instead of a plain hyphen?

Yes, our Style Guide recommends to use the em dash in definition lists and where the sentence has a greater pause or where a clarification follows.
Our docs don't render an em dash when we use a plain hyphen.

@dimodi
Copy link
Contributor

dimodi commented Feb 23, 2022

OK, but shouldn't we put spaces around the mdash then? It looks weird to me like that.

@yordan-mitev
Copy link
Contributor Author

OK, but shouldn't we put spaces around the mdash then? It looks weird to me like that.

The spaces around the em dash are another aspect of its usage and the Style Guide says that we never surround it with spaces. The same rule is embraced by the Google Style Guide, APA Style Guide, and many others.

@github-actions
Copy link
Contributor

Here you are the link to your PR to production: 802

@github-actions github-actions bot deleted the update-figma-kit-article branch February 24, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants