docs: add personal-finance demo #3150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a personal finance demo for Kendo React, implementing various UI components (Investments, Home, Analytics, AI Assistant, etc.) to showcase financial data presentation.
- Adds new pages/components for investments, savings, analytics, and an AI assistant demonstration.
- Introduces new layout and navigation components along with updated ESLint configuration and README updates.
Reviewed Changes
Copilot reviewed 64 out of 67 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| examples/kendo-react-personal-finance/src/Investments.tsx | New page displaying investment components. |
| examples/kendo-react-personal-finance/src/HomeComponents/* | New UI components for small cards, savings progress, budget utilization, etc. |
| examples/kendo-react-personal-finance/src/Header.tsx & Footer.tsx | New header and footer components with navigation and branding. |
| examples/kendo-react-personal-finance/src/App.tsx | Main app file wiring up routes and context for currency. |
| examples/kendo-react-personal-finance/src/AnalyticsComponents/Cashflow.tsx | Cashflow chart with drilldown feature for analytics. |
| examples/kendo-react-personal-finance/src/AIAssistantComponents/* | Components to power the AI Assistant demo. |
| examples/kendo-react-personal-finance/eslint.config.js & README.md | Updated project configuration and documentation. |
Files not reviewed (3)
- examples/kendo-react-personal-finance/.gitignore: Language not supported
- examples/kendo-react-personal-finance/index.html: Language not supported
- examples/kendo-react-personal-finance/package.json: Language not supported
Comments suppressed due to low confidence (1)
examples/kendo-react-personal-finance/src/AnalyticsComponents/Cashflow.tsx:204
- The parameter name in drilldownSeriesFactory appears to use a non-standard character (possibly a Cyrillic 'е' instead of the Latin 'e'), which may be confusing. Consider replacing it with the standard Latin 'e' for clarity.
drilldownSeriesFactory={(е) => Drilldown({ ...е, color: item.color })}
examples/kendo-react-personal-finance/src/AnalyticsComponents/Cashflow.tsx
Show resolved
Hide resolved
PekoPPT
force-pushed
the
add-personal-finance
branch
from
869c603 to
eb9d769
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR implements a new personal-finance demo for the Kendo React application, adding a suite of components spanning investments, home overview, analytics, and an AI assistant. Key changes include new pages (Investments, Analytics, AI Assistant), new components (SmallCard, Savings, BudgetUtilization, CashFlowChart, RelatedTopics, AIPrompt, AIChat), and updates to routing and ESLint configuration.
Reviewed Changes
Copilot reviewed 64 out of 67 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Investments.tsx | Introduces the Investments page with essential investment components. |
| src/HomeComponents/SmallCard.tsx | Provides an overview card used in the Home page. |
| src/HomeComponents/SavingsProgressbar.tsx | Adds a progress bar component for visualizing savings. |
| src/HomeComponents/Savings.tsx | Displays multiple savings categories; note the naming inconsistency with the imported progress bar. |
| src/HomeComponents/BudgetUtilization.tsx | Implements a budget utilization component using an ArcGauge. |
| src/Home.tsx | Arranges Home page components into a cohesive layout. |
| src/Header.tsx | Adds a header with navigation and search functionality. |
| src/Footer.tsx | Introduces a new footer for the demo. |
| src/App.tsx | Updates routing and context management with the new demo pages. |
| src/AnalyticsComponents/Cashflow.tsx | Implements a CashFlow chart with drilldown capability. |
| src/Analytics.tsx | Creates the Analytics page integrating new charts and grids. |
| src/AIAssistantComponents/RelatedTopics.tsx | Provides a related topics panel for the AI assistant. |
| src/AIAssistantComponents/AIPrompt.tsx | Adds an AI prompt component that handles user queries with suggestions. |
| src/AIAssistantComponents/AIChat.tsx | Delivers an AI chat interface wrapped in a styled card. |
| src/AIAssistant.tsx | Introduces the AI Assistant page bringing together related topics and chat. |
| eslint.config.js | Updates the ESLint configuration with proper rules and plugin integration. |
| README.md | Updates documentation for the new demo setup. |
Files not reviewed (3)
- examples/kendo-react-personal-finance/.gitignore: Language not supported
- examples/kendo-react-personal-finance/index.html: Language not supported
- examples/kendo-react-personal-finance/package.json: Language not supported
Comments suppressed due to low confidence (2)
examples/kendo-react-personal-finance/src/HomeComponents/Savings.tsx:4
- There is an inconsistency between the imported name 'SavingsProgressBar' and the filename 'SavingsProgressbar.tsx'. Consider standardizing the naming convention (e.g., 'SavingsProgressBar') across both the file and its usage.
import SavingsProgressBar from "./SavingsProgressbar";
examples/kendo-react-personal-finance/src/AnalyticsComponents/Cashflow.tsx:200
- Ensure that the parameter 'е' is the standard ASCII letter 'e' rather than a visually similar Unicode character to avoid potential issues with tooling or code readability.
drilldownSeriesFactory={(е) => Drilldown({ ...е, color: item.color })}
| const App = () => { | ||
| const [activeView, setActiveView] = React.useState(promptViewDefaults.name); | ||
| const [outputs, setOutputs] = React.useState([]); | ||
| const handleOnRequest = (prompt, output) => { |
There was a problem hiding this comment.
[nitpick] The function 'handleOnRequest' contains repetitive code blocks that process the prompt in similar ways. Refactor these branches to consolidate common logic and improve maintainability.
PaskalevStoyan
approved these changes
May 23, 2025
boryanaT
approved these changes
May 23, 2025
Collaborator
|
The app has be added to dependabot.yml and a build step in ci.yml. But lets do it in a separate pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements: https://github.com/telerik/kendo-react-private/issues/5425