This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
fix(upload): failed to upload item icon color #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyoshev
reviewed
Mar 10, 2017
There was a problem hiding this comment.
I suspect this will need to be applied to the bootstrap theme, too? If so, it would be great if we can reuse these styles, as mentioned earlier. Is there a problem in providing variables and reusing the theme file?
|
I believe that using variables is OK. @gyoshev , should I make the changes here or in a different branch / commit? |
|
This branch is OK, the changes will be added to the PR, so we can continue the discussion. |
joneff
approved these changes
Mar 10, 2017
|
@gyoshev , I made the requested changes |
|
We can merge after the variable name suggestions from the theme-bootstrap issue get fixed here. |
gyoshev
approved these changes
Mar 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to telerik/kendo-angular-upload#50