Skip to content
This repository has been archived by the owner. It is now read-only.

chore(dropdowns): update dropdowns styling because of changed rendering #388

Merged
merged 3 commits into from Apr 13, 2017

Conversation

Projects
None yet
3 participants
@inikolova
Copy link
Contributor

commented Apr 12, 2017

@inikolova inikolova requested review from joneff and gyoshev Apr 12, 2017

.k-state-disabled & {
&::selection {
@include appearance( "input" );
background-color: transparent;

This comment has been minimized.

Copy link
@gyoshev

gyoshev Apr 13, 2017

Contributor

Seems more appropriate to use color: $input-color instead of appearance( "input" ), as the selection doesn't have a border and the background-color is overwritten

This comment has been minimized.

Copy link
@joneff

joneff Apr 13, 2017

Member

Agreed.

@joneff

joneff approved these changes Apr 13, 2017

@inikolova inikolova merged commit 26c3912 into master Apr 13, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@inikolova inikolova deleted the popup_updated_styling branch Apr 13, 2017

inikolova added a commit that referenced this pull request Apr 18, 2017

fix(dropdowns): update dropdowns styling because of changed rendering (
…#388)

* chore(dropdowns): update dropdowns styling because of changed rendering

* fix: selection in disabled input appearance
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.