Skip to content
This repository has been archived by the owner. It is now read-only.

feat(grid): set height on container #400

Merged
merged 4 commits into from Apr 20, 2017

Conversation

Projects
None yet
4 participants
@gyoshev
Copy link
Contributor

commented Apr 20, 2017

This allows the grid height to be set on the container, and resizes the grid accordingly. Works also when the grid height not set. Should be merged in sync with the grid PR that adds .k-grid-container for NG2. Seems to be working fine with the jQuery component, too.

gyoshev added some commits Apr 14, 2017

feat: set grid size based on container height
use flexbox to layout the grid content instead of setting height to inner element

@gyoshev gyoshev added the enhancement label Apr 20, 2017

@gyoshev gyoshev requested review from joneff and inikolova Apr 20, 2017

@joneff

joneff approved these changes Apr 20, 2017

@gyoshev gyoshev merged commit 7aacef2 into master Apr 20, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@gyoshev gyoshev deleted the grid-variable-height branch Apr 20, 2017

@sprell

This comment has been minimized.

Copy link

commented May 4, 2017

It looks like this change broke the jQuery grid when locked columns are in use. It will no longer display the unlocked columns correctly. I verified that it is working correctly in v2.30.0, but not in v2.31.0 (which looks to have only this change in it).

I have an example where I changed this jQuery grid demo...
http://demos.telerik.com/kendo-ui/grid/frozen-columns
...to use the new @progress/kendo-theme-default.

Here is the modified version...
http://dojo.telerik.com/aNUSa

All I did was replace the existing CSS with this...
http://www.telerik.com/kendo-angular-ui/npm/node_modules//@progress/kendo-theme-default/dist/all.css

@gyoshev

This comment has been minimized.

Copy link
Contributor Author

commented May 4, 2017

@sprell this is resolved in 5d23b09 -- the latest Kendo UI for jQuery release includes the k-display-block class; until you upgrade, feel free to set the class to the grid:

// 2017.1 and below
<div id="grid" class="k-display-block"></div>

Here is the updated Dojo with the latest release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.