Telegram struct serializing similar to original (skip empty/defaults)

[Olegt0rr]

Close #863

Solution

• add serde_with_macros::skip_serializing_none to every Telegram struct by default to exclude empty fields
• add skip_serializing_if = "std::ops::Not::not" to exclude False to "True or absent" fields
• add skip_serializing_if = "Vec::is_empty" to exclude empty [ ]

[Olegt0rr]

@WaffleLapkin PR still not completed.
If the declared solution suits, I will fix it for other structures – let me know :)

[WaffleLapkin]

The general approach looks good to me! Most/all of these annotations I just forgot to add 😅

While round-tripping json through our structures preserving the exact form is not our primary goal, it's still good to have.

Also look out for our custom de/serialize impls and more typed reinterpretations (an enum instead of bunch of options, etc) — they historically caused a few bugs and can easily influence round-tripability.

[WaffleLapkin]

BTW you don't need = "Vec::new", since Vec implements Default. If you could replace existing mentions of default = "Vec::new " with default that would be nice.

[Olegt0rr]

Agree, fixed

[WaffleLapkin]

I don't think this is fixed... have you maybe forgot to push the commit?

[Olegt0rr]

@WaffleLapkin, did you mean:

#[serde(skip_serializing_if = "Vec::is_empty", default)]

?

[WaffleLapkin]

Yes

[WaffleLapkin]

@Olegt0rr you still did not address this comment, there are still default = "Vec::new" in the message.rs

[WaffleLapkin]

@hirrolot I think this still wasn't addressed

[Olegt0rr]

Just removed redundant "Vec::new"

[WaffleLapkin]

Ping, @Olegt0rr do you still intend to work on this?

[hirrolot]

@WaffleLapkin, could you review this PR?

[WaffleLapkin]

Thanks!