triable bot #913
Merged
triable bot #913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WaffleLapkin
suggested changes
Aug 19, 2023
WaffleLapkin
added
S-waiting-on-author
Contributor
Author
|
Ok @WaffleLapkin, your project, your rules, hail to the maintainer. |
Contributor
Author
|
What do you dislike @TheAwiteb ? |
Contributor
WaffleLapkin
left a comment
WaffleLapkin
left a comment
There was a problem hiding this comment.
@hirrolot could you also take a look?
Co-authored-by: Waffle Maybe <waffle.lapkin@gmail.com>
LGTM Co-authored-by: Waffle Maybe <waffle.lapkin@gmail.com>
WaffleLapkin
added
S-waiting-on-review
WaffleLapkin
previously approved these changes
Sep 25, 2023
Contributor
WaffleLapkin
left a comment
WaffleLapkin
left a comment
There was a problem hiding this comment.
LGTM, but want a second opinion from @hirrolot
hirrolot
reviewed
Sep 26, 2023
…d an unused link def to ShutdownToken::shutdown
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request for maintainers comments
These changes allow me to embed the bot in another app, I can handle a complete connection loss without panicking the all app, and the bot is back online when the network is plugged in again.
Yet to do :