Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify kafka producers in fl #1360

Merged
merged 3 commits into from Oct 23, 2018

Conversation

@surabujin
Copy link
Collaborator

surabujin commented Sep 19, 2018

Change list:

  • merge modules KafkaMessageCollector and KafkaMessageProducer - move kafka-producer into KafkaMessageCollector and represent it as a IFloodlightService
  • drop usage of private kafka-producer in PathVerificationService
  • use share kafka-producer in PathVerificationService

Close #1340

Copy link

sonarcloud bot left a comment

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 8

See all issues in SonarCloud

@surabujin

This comment has been minimized.

Copy link
Collaborator Author

surabujin commented Sep 20, 2018

Blocked by #1363

@surabujin surabujin force-pushed the unify-kafka-producers-in-FL branch from 51ea3f6 to ed86c70 Sep 20, 2018
Copy link

sonarcloud bot left a comment

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 4

See all issues in SonarCloud

@surabujin surabujin force-pushed the unify-kafka-producers-in-FL branch from bc8d31d to 92c90fe Oct 11, 2018
Copy link

sonarcloud bot left a comment

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 3

See all issues in SonarCloud

surabujin added 3 commits Sep 18, 2018
Switch to use KafkaProducerService instead of private kafka-producer.
Include new KafkaProducerService into KafkaMessageConsumer module.
@surabujin surabujin force-pushed the unify-kafka-producers-in-FL branch from 92c90fe to d2cf5ef Oct 12, 2018
Copy link

sonarcloud bot left a comment

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 3

See all issues in SonarCloud

@@ -25,16 +23,10 @@
import org.slf4j.LoggerFactory;

// TODO(surabujin): avoid usage, replace with more correct network interrupting method

This comment has been minimized.

Copy link
@sonarcloud

sonarcloud bot Oct 12, 2018

Code Smell Code Smell: Complete the task associated to this TODO comment. (squid:S1135)

See it in SonarCloud

}

@NewCorrelationContextRequired
private void timerAction() {

This comment has been minimized.

Copy link
@sonarcloud

sonarcloud bot Oct 12, 2018

Code Smell Code Smell: Move this method into "Action". (squid:S3398)

See it in SonarCloud

}
}

private void reportError(String topic, Message message, Exception e) {

This comment has been minimized.

Copy link
@sonarcloud

sonarcloud bot Oct 12, 2018

Code Smell Code Smell: Move this method into "SendStatusCallback". (squid:S3398)

See it in SonarCloud

@nikitacherevko nikitacherevko merged commit 24649d1 into develop Oct 23, 2018
4 checks passed
4 checks passed
SonarCloud Code Quality check passed; 32.8% Est. post-merge coverage
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
telstra-jenkins/kilda-ATDD-runner Build 1741: tests PASSED
@nikitacherevko nikitacherevko deleted the unify-kafka-producers-in-FL branch Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.