Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional/preemptive flow remove #1425

Merged
merged 2 commits into from Oct 11, 2018

Conversation

@rtretyak
Copy link
Collaborator

rtretyak commented Oct 2, 2018

No description provided.

@rtretyak rtretyak requested a review from npliashechnikov Oct 2, 2018
@rtretyak rtretyak force-pushed the functional/preemptive_flow_remove branch from a115f43 to bfb19e8 Oct 2, 2018
rules.missingRules.empty && rules.excessRules.empty
}
and: "Bring port back up"

This comment has been minimized.

Copy link
@npliashechnikov

npliashechnikov Oct 9, 2018

Collaborator

It'd be nice to additionally ensure that port gets back up (in cleanup or something)

This comment has been minimized.

Copy link
@rtretyak

rtretyak Oct 10, 2018

Author Collaborator

In order to make sure that system was reverted to original state and next tests are allowed to run I do Wrappers.wait(WAIT_OFFSET) { northboundService.getAllLinks().every { it.state != IslChangeType.FAILED } } on line 325. In ensures that the port is up and the related link was again discovered.
Verifying that 'port up' operation made the port to be up is not the goal of this test. Port up/down functionality is tested in a separate spec

@surabujin surabujin merged commit ac8904e into develop Oct 11, 2018
4 checks passed
4 checks passed
SonarCloud Code Quality check passed; 32.5% Est. post-merge coverage
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
telstra-jenkins/kilda-ATDD-runner Build 1655: tests PASSED
@surabujin surabujin deleted the functional/preemptive_flow_remove branch Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.