Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(lint): add some linting meta files #163

Merged
merged 13 commits into from Aug 29, 2018

Conversation

@ahmadnassri
Copy link
Contributor

commented Aug 28, 2018

Ensure better quality through linting and IDE configuration

  • EditorConfig
  • Markdown Lint

  • provide a descriptive topic
  • provide an overview of contribution
  • no sensitive content included, such as:
    • security & privacy policy violating content
    • content considered competitive intelligence
    • keys, tokens or credentials
  • documentation format follows this template
  • fork is up to date (see this guide from github)
  • "work in progress" commits are squashed (see "Squashing Commits")
  • commits follow the Karma or Commitizen format
@ruxandrafed

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2018

Not merging yet until we configure CI for this and fix all markdown warnings, etc.

ruxandrafed and others added 12 commits Aug 28, 2018
…ing reviewers (#164)
* expanded more on the redux concept

* feat(docs): more Redux details
Copy link
Contributor

left a comment

The editor config checker complains about stuff in my .idea folder 😝, but fine .. (not moving to VSCode yet!)

@ruxandrafed ruxandrafed merged commit bd23f10 into master Aug 29, 2018
@ahmadnassri ahmadnassri deleted the meta-files branch Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.