Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(redux): revisions and grammar #199

Merged
merged 11 commits into from Feb 18, 2019

Conversation

@ryanscovill
Copy link
Contributor

commented Nov 8, 2018

Overview

This is a revision edit for a course that @kkwoker is also taking.

Details

Minor sentence changes for formality and ease of reading/understanding.
Changed ordered lists to unordered as no inherent structure is apparent
Fix typos and grammar

Meta

  • provided a descriptive topic and overview of contribution
  • documentation format follows the topic template
  • fork is up to date (Hint: "Syncing a Fork")
  • "work in progress" commits are squashed (Hint: "Squashing Commits")
  • commits follow the Conventional ChangeLog format
  • no sensitive content included, such as:
    • content considered competitive intelligence
    • security & privacy policy violating content
    • keys, tokens or credentials
Minor sentence changes for formality and ease of reading/understanding
Changed ordered lists to unordered as no inherent structure is apparent 
Fix spelling and grammar
@ryanscovill ryanscovill requested a review from telus/platform-technology-tools as a code owner Nov 8, 2018
Copy link
Contributor

left a comment

Thanks for reviewing, @ryanscovill! Just noticed some of the changes you made increased readability, so I went ahead and suggested some similar ones, also in the interest of staying consistent (just removed a lot of capitalized words).

development/redux.md Outdated Show resolved Hide resolved
development/redux.md Outdated Show resolved Hide resolved
development/redux.md Outdated Show resolved Hide resolved
development/redux.md Outdated Show resolved Hide resolved
development/redux.md Outdated Show resolved Hide resolved
development/redux.md Outdated Show resolved Hide resolved
development/redux.md Outdated Show resolved Hide resolved
development/redux.md Outdated Show resolved Hide resolved
development/redux.md Outdated Show resolved Hide resolved
ruxandrafed and others added 9 commits Nov 13, 2018
Co-Authored-By: ryanscovill <ryans797@gmail.com>
Co-Authored-By: ryanscovill <ryans797@gmail.com>
Co-Authored-By: ryanscovill <ryans797@gmail.com>
Co-Authored-By: ryanscovill <ryans797@gmail.com>
Co-Authored-By: ryanscovill <ryans797@gmail.com>
Yes, good catch!

Co-Authored-By: ryanscovill <ryans797@gmail.com>
Co-Authored-By: ryanscovill <ryans797@gmail.com>
Co-Authored-By: ryanscovill <ryans797@gmail.com>
Co-Authored-By: ryanscovill <ryans797@gmail.com>
@ruxandrafed

This comment has been minimized.

Copy link
Contributor

commented Nov 29, 2018

@ryanscovill Do you still have some time to look at this? Thanks!

@ruxandrafed ruxandrafed force-pushed the telus:master branch 4 times, most recently from 01c57e2 to 8051fa5 Jan 14, 2019
@ruxandrafed ruxandrafed merged commit a6897ae into telus:master Feb 18, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@telusdigitaldelivery

This comment has been minimized.

Copy link

commented Feb 18, 2019

🎉 This PR is included in version 1.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.