Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(contrast): Doc update #207

Merged
merged 2 commits into from Dec 7, 2018

Conversation

@cianscott
Copy link
Contributor

commented Dec 4, 2018

Added additional information on why this is necessary, clarity on both Contrast features (Assess and Protect) and how they work.

Overview

Describe your change in detail

Forum Issue # telus/technology-forum#0

Link to the Technology Forum where this issue was discussed (optional).

Details

e.g.

  • add something to existing topic
  • create new topic
  • adjust grammar & typos

Meta

Please read and confirm each of the following:

  • this topic was discussed in the Technology Forum (ignore if the pull request represents small changes)
  • provided a descriptive topic and overview of contribution
  • documentation format follows the topic template
  • fork is up to date (Hint: "Syncing a Fork")
  • "work in progress" commits are squashed (Hint: "Squashing Commits")
  • commits follow the Conventional ChangeLog format
  • no sensitive content included, such as:
    • content considered competitive intelligence
    • security & privacy policy violating content
    • keys, tokens or credentials
Added additional information on why this is necessary, clarity on both Contrast features (Assess and Protect) and how they work.
@cianscott cianscott requested review from isand3r and tavogel Dec 4, 2018
@cianscott cianscott requested a review from telus/platform-technology-tools as a code owner Dec 4, 2018
@isand3r
isand3r approved these changes Dec 4, 2018
@isand3r

This comment has been minimized.

Copy link

commented Dec 4, 2018

hmmm looks like there's an issue with the linting pipeline: Error: Could not find module @telus/remark-preset-lint-markdown

@tavogel any ideas?

@ruxandrafed

This comment has been minimized.

Copy link
Contributor

commented Dec 7, 2018

@isand3r Ahmad has updated the name of that package and we have to fix this repo! I'll fix :)

fix(lint-fix) pull lint package fix
@isand3r isand3r removed the request for review from tavogel Dec 7, 2018
@ruxandrafed ruxandrafed merged commit 1201057 into master Dec 7, 2018
1 check passed
1 check passed
run Workflow: run
Details
@cianscott cianscott deleted the chore(contrast)-Doc-update branch Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.