Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(css): add styled-components #224

Merged
merged 1 commit into from Mar 5, 2019

Conversation

@jraff
Copy link
Contributor

commented Feb 13, 2019

Overview

This is a PR adds styled-components as the css standard to Reference Architecture.

Forum Issue # telus/technology-forum#161


Meta

Please read and confirm each of the following:

  • this topic was discussed in the Technology Forum (ignore if the pull request represents small changes)
  • provided a descriptive topic and overview of contribution
  • documentation format follows the topic template
  • branch is up to date with master
  • "work in progress" commits are squashed (Hint: "Squashing Commits")
  • commits follow the Conventional ChangeLog format
  • no sensitive content included, such as:
    • content considered competitive intelligence
    • security & privacy policy violating content
    • keys, tokens or credentials
@jraff jraff requested a review from telus/platform-technology-tools as a code owner Feb 13, 2019
@jraff jraff force-pushed the styled-components branch from 2537271 to f47ed49 Feb 13, 2019
@ruxandrafed ruxandrafed self-assigned this Feb 13, 2019
- Follow the "styled component" pattern by attaching styles directly to components.
- Push logic out of CSS into JavaScript (such as animations, pseudo-states such as :hover/:focus, media queries) so that the code is easier to reason about, test, and maintain.
- Share functionality via components instead of CSS classes (even layout or animations can be created as components).
- Recommend that object notation is used with the [css prop](https://www.styled-components.com/docs/api#css-prop) when writing styled-components

This comment has been minimized.

Copy link
@ruxandrafed

ruxandrafed Feb 15, 2019

Contributor

Could we please rephrase these?

  • Use object notation..
  • Reuse existing components before creating...
  • Share functionality such as layouts and animations via components..
  • Sanitize user input.. etc.
@jraff jraff force-pushed the styled-components branch from f47ed49 to e421bc7 Feb 22, 2019
@jraff jraff force-pushed the styled-components branch from e421bc7 to 1e9bf7e Feb 22, 2019
@ruxandrafed ruxandrafed merged commit bb7059d into master Mar 5, 2019
2 checks passed
2 checks passed
Semantic Pull Request ready to be squashed
Details
default Workflow: default
Details
@telusdigitaldelivery

This comment has been minimized.

Copy link

commented Mar 5, 2019

🎉 This PR is included in version 1.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@ruxandrafed ruxandrafed deleted the styled-components branch Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.