Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(seo): Update seo.md #235

Merged
merged 3 commits into from Sep 25, 2019

Conversation

@danielcrough
Copy link
Contributor

danielcrough commented Sep 25, 2019

Overview

Updating the page title standards.

Meta

Please read and confirm each of the following:

  • this topic was discussed in the Technology Forum (ignore if the pull request represents small changes)
  • provided a descriptive topic and overview of contribution
  • documentation format follows the topic template
  • branch is up to date with master
  • "work in progress" commits are squashed (Hint: "Squashing Commits")
  • commits follow the Conventional ChangeLog format
  • no sensitive content included, such as:
    • content considered competitive intelligence
    • security & privacy policy violating content
    • keys, tokens or credentials
@karlasamantha karlasamantha changed the title Update seo.md feat(seo): Update seo.md Sep 25, 2019
@danielcrough

This comment has been minimized.

Copy link
Contributor Author

danielcrough commented Sep 25, 2019

@maumercado can you help here? Not sure why this is blocked.

@danielcrough

This comment has been minimized.

Copy link
Contributor Author

danielcrough commented Sep 25, 2019

or @karlasamantha , sorry didn't see you were already looking at this.

@mattcan

This comment has been minimized.

@danielcrough

This comment has been minimized.

Copy link
Contributor Author

danielcrough commented Sep 25, 2019

@mattcan yes, thank you. Not sure what I did wrong but that looks right!

@mattcan mattcan merged commit 9ba8c15 into master Sep 25, 2019
2 checks passed
2 checks passed
Semantic Pull Request ready to be squashed
Details
default Workflow: default
Details
@mattcan

This comment has been minimized.

Copy link

mattcan commented Sep 25, 2019

You were creating a link in two different places. To be fair, it was done incorrectly before your change was added. The backslashes I added are so that the renderer knows to ignore the < and [ characters.

Here is how links work in Markdown: https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet#links

@mattcan mattcan deleted the danielcrough-patch-2 branch Sep 25, 2019
@telusdigitaldelivery

This comment has been minimized.

Copy link

telusdigitaldelivery commented Sep 25, 2019

🎉 This PR is included in version 1.16.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.