Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-step-tracker): make full width, add bg colour options #858

Merged
merged 1 commit into from Dec 12, 2018

Conversation

marcod1419
Copy link
Contributor

@marcod1419 marcod1419 commented Dec 10, 2018

See: #731

This makes step tracker full width while also making the background colour grey by default. It includes a new backgroundColour prop to switch the background to white if preferred.

@TDSBot
Copy link

TDSBot commented Dec 10, 2018

Changes:
 - @tds/core-flex-grid: 2.3.0 => 2.3.1
 - @tds/core-notification: 1.2.3 => 1.2.4
 - @tds/core-price-lockup: 1.0.2 => 1.0.3
 - @tds/core-step-tracker: 2.0.3 => 2.1.0


🤔 If this is not what you expected, ensure that your commit messages follow the Conventional Commits specification (https://conventionalcommits.org) and try again.

🚀 Please paste the entire output of this task into the body of your Pull Request so that a maintainer can verify before merging/publishing.

1 similar comment
@TDSBot
Copy link

TDSBot commented Dec 10, 2018

Changes:
 - @tds/core-flex-grid: 2.3.0 => 2.3.1
 - @tds/core-notification: 1.2.3 => 1.2.4
 - @tds/core-price-lockup: 1.0.2 => 1.0.3
 - @tds/core-step-tracker: 2.0.3 => 2.1.0


🤔 If this is not what you expected, ensure that your commit messages follow the Conventional Commits specification (https://conventionalcommits.org) and try again.

🚀 Please paste the entire output of this task into the body of your Pull Request so that a maintainer can verify before merging/publishing.

Copy link
Contributor

@jraff jraff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be a breaking change.

@@ -27,7 +27,8 @@
"dependencies": {
"@tds/core-box": "^1.0.1",
"@tds/core-decorative-icon": "^1.0.0",
"@tds/core-text": "^1.0.3",
"@tds/core-flex-grid": "^2.3.0",
"@tds/core-text": "^1.0.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like core-text was downgraded.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird. Will fix.

}

.whiteBg {
background-color: #ffffff;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use $color-white here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

@marcod1419
Copy link
Contributor Author

@jraff It is. Just forgot to add the indicator! I'll do that now.

BREAKING CHANGE: make step tracker full width
@TDSBot
Copy link

TDSBot commented Dec 11, 2018

Changes:
 - @tds/core-expand-collapse: 1.2.1 => 1.2.2
 - @tds/core-flex-grid: 2.3.0 => 2.3.1
 - @tds/core-hairline-divider: 1.0.0 => 1.0.1
 - @tds/core-notification: 1.2.3 => 1.2.4
 - @tds/core-price-lockup: 1.0.2 => 1.0.3
 - @tds/core-step-tracker: 2.0.3 => 3.0.0


🤔 If this is not what you expected, ensure that your commit messages follow the Conventional Commits specification (https://conventionalcommits.org) and try again.

🚀 Please paste the entire output of this task into the body of your Pull Request so that a maintainer can verify before merging/publishing.

1 similar comment
@TDSBot
Copy link

TDSBot commented Dec 11, 2018

Changes:
 - @tds/core-expand-collapse: 1.2.1 => 1.2.2
 - @tds/core-flex-grid: 2.3.0 => 2.3.1
 - @tds/core-hairline-divider: 1.0.0 => 1.0.1
 - @tds/core-notification: 1.2.3 => 1.2.4
 - @tds/core-price-lockup: 1.0.2 => 1.0.3
 - @tds/core-step-tracker: 2.0.3 => 3.0.0


🤔 If this is not what you expected, ensure that your commit messages follow the Conventional Commits specification (https://conventionalcommits.org) and try again.

🚀 Please paste the entire output of this task into the body of your Pull Request so that a maintainer can verify before merging/publishing.

Copy link
Contributor

@jraff jraff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jraff jraff merged commit 08bf3ee into master Dec 12, 2018
@jraff jraff deleted the feat/full-width-steptracker branch December 12, 2018 19:04
jraff pushed a commit that referenced this pull request Dec 17, 2018
BREAKING CHANGE: make step tracker full width
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants