New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core-step-tracker): make full width, add bg colour options #858
Conversation
c7d5821
to
e15eaef
Compare
|
1 similar comment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be a breaking change.
packages/StepTracker/package.json
Outdated
@@ -27,7 +27,8 @@ | |||
"dependencies": { | |||
"@tds/core-box": "^1.0.1", | |||
"@tds/core-decorative-icon": "^1.0.0", | |||
"@tds/core-text": "^1.0.3", | |||
"@tds/core-flex-grid": "^2.3.0", | |||
"@tds/core-text": "^1.0.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like core-text was downgraded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird. Will fix.
} | ||
|
||
.whiteBg { | ||
background-color: #ffffff; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use $color-white
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
@jraff It is. Just forgot to add the indicator! I'll do that now. |
e15eaef
to
b792633
Compare
BREAKING CHANGE: make step tracker full width
b792633
to
11918d4
Compare
|
1 similar comment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
BREAKING CHANGE: make step tracker full width
See: #731
This makes step tracker full width while also making the background colour grey by default. It includes a new backgroundColour prop to switch the background to white if preferred.