Skip to content

refactor(router): refactor router logic to middleware #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 26, 2025
Merged

refactor(router): refactor router logic to middleware #1307

merged 10 commits into from
Jun 26, 2025

Conversation

@brendt
Copy link
Member

@brendt brendt commented Jun 26, 2025 •
edited
Loading

Closes #1306
Closes #1304

@brendt brendt marked this pull request as draft June 26, 2025 08:19
brendt
brendt commented Jun 26, 2025
View reviewed changes
@brendt brendt requested a review from innocenzi June 26, 2025 09:09
@brendt brendt marked this pull request as ready for review June 26, 2025 09:09
@brendt
Copy link
Member Author

brendt commented Jun 26, 2025 •
edited
Loading

TODO:

  • write a test for adding a custom exception handler middleware

@brendt
Copy link
Member Author

brendt commented Jun 26, 2025

TODO:

  • Document Priority::EXCEPTION_HANDLING
  • Document that route-specific middleware is prioritized separately

@brendt brendt merged commit c17719b into main Jun 26, 2025
68 checks passed
@brendt brendt deleted the router-middleware branch June 26, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@innocenzi innocenzi Awaiting requested review from innocenzi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Handle route exceptions via middleware Exception processors should be middleware

3 participants

@brendt @innocenzi