Visit OperatorService methods in interceptor #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Oct 15, 2024
Member
cretz
left a comment
cretz
left a comment
There was a problem hiding this comment.
It is a bit rough that I'm allowed to encrypt endpoint descriptions if I self host but not in cloud. Arguably we should not have made self-hosted descriptions payloads.
Member
Author
|
We want to allow encryption in Cloud too. There's a planned breaking change to switch the description field to a payload once we figure out how cloud / and OSS protos are going to be combined. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
generatorcheckMakefile targetWhy?
There are payloads in the Nexus EndpointSpec description that need to be visited for completeness.