Replace buildkite with GHA #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will require changes to our repo security settings to the CI pipeline as a required step
| docker: "*" | ||
| command: "make ci-build" | ||
| plugins: | ||
| - docker-compose#v3.1.0: |
There was a problem hiding this comment.
Am I missing something or did we remove the docker and docker compose file? Was it not needed?
There was a problem hiding this comment.
These aren't needed for GHA at least. No idea if they were for buildkite: I've not worked with it
Quinn-With-Two-Ns
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Our Buildkite CI config was replaced with GitHub actions
Why?
We're trying to deprecate buildkite in general; the server repo has already done so
Breaking changes
None.