Skip to content

Conversation

@yuandrew
Copy link
Contributor

@yuandrew yuandrew commented Nov 18, 2025

What was changed

Remove a check that max_cached_workflows must match worker_types config settings.

Why?

Decided this is an unnecessary check, worker_types already trumps other config settings for configuring which pollers to initializer.

Hopefully this reduces the number of breaks for user configs

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

Note

Removes the validation that disallowed max_cached_workflows > 0 when workflows are disabled, and deletes the corresponding test.

  • Validation (worker config):
    • Remove constraint preventing max_cached_workflows > 0 when task_types.enable_workflows is false in crates/common/src/worker.rs.
  • Tests:
    • Delete test_workflow_cache_without_workflows_fails from crates/common/tests/worker_task_types_test.rs.

Written by Cursor Bugbot for commit 8e28e97. This will update automatically on new commits. Configure here.

@yuandrew yuandrew requested a review from a team as a code owner November 18, 2025 18:32
@yuandrew yuandrew changed the title Remove check to decrease user breaks Remove check between worker_types and max_cached_workflows Nov 18, 2025
@yuandrew yuandrew enabled auto-merge (squash) November 18, 2025 18:40
@yuandrew yuandrew merged commit b4bb678 into temporalio:master Nov 18, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants