Remove check between worker_types and max_cached_workflows #1063
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Remove a check that
max_cached_workflowsmust matchworker_typesconfig settings.Why?
Decided this is an unnecessary check, worker_types already trumps other config settings for configuring which pollers to initializer.
Hopefully this reduces the number of breaks for user configs
Checklist
Closes
How was this tested:
Note
Removes the validation that disallowed
max_cached_workflows> 0 when workflows are disabled, and deletes the corresponding test.max_cached_workflows> 0 whentask_types.enable_workflowsis false incrates/common/src/worker.rs.test_workflow_cache_without_workflows_failsfromcrates/common/tests/worker_task_types_test.rs.Written by Cursor Bugbot for commit 8e28e97. This will update automatically on new commits. Configure here.