From e875da85de77f8e15251bd80eba6436e0f2161f3 Mon Sep 17 00:00:00 2001 From: Spencer Judge Date: Tue, 12 Jan 2021 15:55:57 -0800 Subject: [PATCH 1/2] Submodule URLs are weird --- .gitmodules | 2 +- README.md | 8 ++++++++ protos/core_interface.proto | 3 ++- 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/.gitmodules b/.gitmodules index 1f49b5a57..76a71369a 100644 --- a/.gitmodules +++ b/.gitmodules @@ -1,3 +1,3 @@ [submodule "protos/api_upstream"] path = protos/api_upstream - url = git@github.com:temporalio/api.git + url = git://github.com:temporalio/api.git diff --git a/README.md b/README.md index 660e0f312..1e3c8510c 100644 --- a/README.md +++ b/README.md @@ -1 +1,9 @@ Core SDK that can be used as a base for all other SDKs. + +# Getting started +This repo uses a submodule for upstream protobuf files. The path `protos/api_upstream` is a +submodule -- when checking out the repo for the first time make sure you've run +`git submodule --init --recursive`. TODO: Makefile. + +## Dependencies +* Protobuf compiler diff --git a/protos/core_interface.proto b/protos/core_interface.proto index 7db4e526f..b486404bd 100644 --- a/protos/core_interface.proto +++ b/protos/core_interface.proto @@ -3,7 +3,8 @@ syntax = "proto3"; package temporal.api.coresdk.v1; // Note: Intellij will think these imports don't work because of the slightly odd nature of -// the include paths. They work. +// the include paths. You can make it work by going to the "Protobuf Support" settings section +// and adding the "api_upstream" subdir as an include path. import "temporal/api/workflowservice/v1/request_response.proto"; import "temporal/api/taskqueue/v1/message.proto"; From 9741a2b8078b8099277cdffbc7a493a0175b62ce Mon Sep 17 00:00:00 2001 From: Spencer Judge Date: Tue, 12 Jan 2021 15:56:56 -0800 Subject: [PATCH 2/2] accidentally a word --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 1e3c8510c..142d0066e 100644 --- a/README.md +++ b/README.md @@ -3,7 +3,7 @@ Core SDK that can be used as a base for all other SDKs. # Getting started This repo uses a submodule for upstream protobuf files. The path `protos/api_upstream` is a submodule -- when checking out the repo for the first time make sure you've run -`git submodule --init --recursive`. TODO: Makefile. +`git submodule update --init --recursive`. TODO: Makefile. ## Dependencies * Protobuf compiler