Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistent tag names between server and sdk #315

Closed
kkcmadhu opened this issue Jan 15, 2021 · 4 comments
Closed

inconsistent tag names between server and sdk #315

kkcmadhu opened this issue Jan 15, 2021 · 4 comments
Assignees

Comments

@kkcmadhu
Copy link

Expected Behavior

Expect to see sdk metrics in the sdk dahboard

Actual Behavior

The sdk metrics do not get populated in this dashboard

Steps to Reproduce the Problem

  1. enable metrics in client
  2. setup graphana/promethus
  3. import sdk dashboard in graphana

Additional Info

The graphana dashboard use names like namespace, workerType etc which seems to be in consistent with tags originated from server (frontend, matcher etc) .i.e https://github.com/temporalio/temporal/blob/master/common/metrics/tags.go (the canary tests which i presumes runs from the worker and the temporal namespace which is only in server shows info here)

But however real namespaces do not endup showing data here because the tag names mismatch (see java sdk and go sdk tags

these do not appear in grafana as the tag names are little different e.g Namespace in sdk and namespace in server, WorkflowType in server etc.

Now should the namespace tag not be same every where.

Now what iam confused is is this discrepancy between server and sdk code , or is it bug in the graphana dashoard json file!

@samarabbas samarabbas transferred this issue from temporalio/temporal Jan 18, 2021
@madhukkc
Copy link

i think the metric tags in java sdk are here

@vitarb
Copy link
Contributor

vitarb commented Jan 19, 2021

Madhu, thanks for reporting, we are aware of this issue and will address it soon.

@vitarb vitarb self-assigned this Jan 21, 2021
@vitarb
Copy link
Contributor

vitarb commented Jan 21, 2021

Following changes should address this issue:
#318
temporalio/sdk-go#345
temporalio/dashboards#8

@vitarb vitarb closed this as completed Jan 21, 2021
@kkcmadhu
Copy link
Author

hi is there a new sdk release for this or should i take latest of 1.04 sdk?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants