From e35b7292579d46c8f1fbf68ee55a938a44723668 Mon Sep 17 00:00:00 2001 From: Vitaly Date: Wed, 4 Nov 2020 19:24:59 -0800 Subject: [PATCH 1/2] Use deamon threads for connection backoff resetor --- .../io/temporal/serviceclient/WorkflowServiceStubsImpl.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/temporal-serviceclient/src/main/java/io/temporal/serviceclient/WorkflowServiceStubsImpl.java b/temporal-serviceclient/src/main/java/io/temporal/serviceclient/WorkflowServiceStubsImpl.java index 0ff053121c..e7d3dde140 100644 --- a/temporal-serviceclient/src/main/java/io/temporal/serviceclient/WorkflowServiceStubsImpl.java +++ b/temporal-serviceclient/src/main/java/io/temporal/serviceclient/WorkflowServiceStubsImpl.java @@ -19,6 +19,7 @@ package io.temporal.serviceclient; +import com.google.common.util.concurrent.ThreadFactoryBuilder; import io.grpc.Channel; import io.grpc.ClientInterceptor; import io.grpc.ClientInterceptors; @@ -168,7 +169,9 @@ public WorkflowServiceStubsImpl( } private ScheduledExecutorService startConnectionBackoffResetter(Duration backoffResetFrequency) { - ScheduledExecutorService executor = Executors.newSingleThreadScheduledExecutor(); + ScheduledExecutorService executor = + Executors.newSingleThreadScheduledExecutor( + new ThreadFactoryBuilder().setDaemon(true).build()); executor.scheduleWithFixedDelay( () -> { From 2d830f136ab1fa0ddeaa5016cbd27090c8c7067e Mon Sep 17 00:00:00 2001 From: Vitaly Date: Wed, 4 Nov 2020 19:45:12 -0800 Subject: [PATCH 2/2] Add a thread name --- .../io/temporal/serviceclient/WorkflowServiceStubsImpl.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/temporal-serviceclient/src/main/java/io/temporal/serviceclient/WorkflowServiceStubsImpl.java b/temporal-serviceclient/src/main/java/io/temporal/serviceclient/WorkflowServiceStubsImpl.java index e7d3dde140..b888ee24ac 100644 --- a/temporal-serviceclient/src/main/java/io/temporal/serviceclient/WorkflowServiceStubsImpl.java +++ b/temporal-serviceclient/src/main/java/io/temporal/serviceclient/WorkflowServiceStubsImpl.java @@ -171,7 +171,10 @@ public WorkflowServiceStubsImpl( private ScheduledExecutorService startConnectionBackoffResetter(Duration backoffResetFrequency) { ScheduledExecutorService executor = Executors.newSingleThreadScheduledExecutor( - new ThreadFactoryBuilder().setDaemon(true).build()); + new ThreadFactoryBuilder() + .setDaemon(true) + .setNameFormat("ConnectionBackoffResetter-thread-%d") + .build()); executor.scheduleWithFixedDelay( () -> {