Skip to content

Only warn on non-passed-through dynamic imports #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2025
Merged

Only warn on non-passed-through dynamic imports #1222

merged 1 commit into from
Nov 24, 2025

Conversation

@VegetarianOrc
Copy link
Contributor

@VegetarianOrc VegetarianOrc commented Nov 24, 2025

What was changed

  • Use sys.stdlib_module_names in _restrictions.py now that we don't have to maintain the list separately for Python 3.9
  • Only warn on dynamic imports that are accidental (i.e. not passed through).

@VegetarianOrc
use sys.stdlib_module_names in restrictions. Move dynamic import warn…
39701dc 
…ing to only apply to non-passed through modules
@VegetarianOrc VegetarianOrc requested a review from a team as a code owner November 24, 2025 18:06
@VegetarianOrc VegetarianOrc merged commit 77f2346 into main Nov 24, 2025
26 of 27 checks passed
@VegetarianOrc VegetarianOrc deleted the dynamic-import-warning-fix branch November 24, 2025 18:50
@promptless promptless bot mentioned this pull request Nov 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tconley1428 tconley1428 tconley1428 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@VegetarianOrc @tconley1428