diff --git a/common/membership/interfaces.go b/common/membership/interfaces.go index 42b2bb50893..70d1d319601 100644 --- a/common/membership/interfaces.go +++ b/common/membership/interfaces.go @@ -53,7 +53,6 @@ type ( // ChangedEvent describes a change in membership ChangedEvent struct { HostsAdded []HostInfo - HostsUpdated []HostInfo HostsRemoved []HostInfo } diff --git a/common/membership/ringpop/monitor_test.go b/common/membership/ringpop/monitor_test.go index 004f42597a5..095137283ff 100644 --- a/common/membership/ringpop/monitor_test.go +++ b/common/membership/ringpop/monitor_test.go @@ -80,7 +80,6 @@ func (s *RpoSuite) TestMonitor() { s.Equal(1, len(e.HostsRemoved), "ringpop monitor event does not report the removed host") s.Equal(testService.hostAddrs[1], e.HostsRemoved[0].GetAddress(), "ringpop monitor reported that a wrong host was removed") s.Nil(e.HostsAdded, "Unexpected host reported to be added by ringpop monitor") - s.Nil(e.HostsUpdated, "Unexpected host reported to be updated by ringpop monitor") case <-time.After(time.Minute): s.Fail("Timed out waiting for failure to be detected by ringpop") } @@ -123,9 +122,6 @@ func (s *RpoSuite) verifyMemberDiff(curr []string, new []string, expectedDiff [] for _, a := range event.HostsAdded { diff = append(diff, "+"+a.GetAddress()) } - for _, a := range event.HostsUpdated { - diff = append(diff, "~"+a.GetAddress()) - } for _, a := range event.HostsRemoved { diff = append(diff, "-"+a.GetAddress()) } diff --git a/service/history/shard/controller_impl.go b/service/history/shard/controller_impl.go index c06c46a6603..02340be6a79 100644 --- a/service/history/shard/controller_impl.go +++ b/service/history/shard/controller_impl.go @@ -368,7 +368,7 @@ func (c *ControllerImpl) shardManagementPump() { c.contextTaggedLogger.Info("", tag.ValueRingMembershipChangedEvent, tag.NumberProcessed(len(changedEvent.HostsAdded)), tag.NumberDeleted(len(changedEvent.HostsRemoved)), - tag.Number(int64(len(changedEvent.HostsUpdated)))) + ) c.acquireShards() } }