From 792b0c4d19b4b32a9cec553811ecb38a4d044b72 Mon Sep 17 00:00:00 2001 From: Alex Shtin Date: Wed, 3 Mar 2021 10:25:17 -0800 Subject: [PATCH] Update CONTRIBUTING.md to go 1.16 (#1348) --- .github/PULL_REQUEST_TEMPLATE.md | 1 + CONTRIBUTING.md | 10 +++++----- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index ac2872b7bc9..d31eeb65849 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -13,5 +13,6 @@ **Potential risks** + **Is hotfix candidate?** diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 8e242f9d0c5..aec84e33f37 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -7,11 +7,11 @@ This doc is for contributors to Temporal Server (hopefully that's you!) ## Prerequisites ### Build prerequisites -* [Go Lang](https://golang.org/) (minimum version required is 1.14): - - Install on OS X with `brew install go`. +* [Go Lang](https://golang.org/) (minimum version required is 1.16): + - Install on macOS with `brew install go`. - Install on Ubuntu with `sudo apt install golang`. -* [Protocol buffers compiler](https://github.com/protocolbuffers/protobuf/): - - Install on OS X with `brew install protobuf`. +* [Protocol buffers compiler](https://github.com/protocolbuffers/protobuf/) (only if you are going to change `proto` files): + - Install on macOS with `brew install protobuf`. - Install on Ubuntu with `sudo apt install protobuf-compiler`. ### Runtime (server and tests) prerequisites @@ -52,7 +52,7 @@ Tests require runtime dependencies. They can be run with `start-dependencies` ta $ make start-dependencies ``` -Before testing on MacOS, make sure you increase the file handle limit: +Before testing on macOS, make sure you increase the file handle limit: ```bash $ ulimit -n 8192 ```