Adds scheduleIdleCloseTime#10439
Merged
davidporter-id-au merged 3 commits intoJun 3, 2026
Merged
Conversation
lina-temporal
approved these changes
Jun 2, 2026
Comment on lines
71
to
+73
| const ScheduleNextActionTimeName = "ScheduleNextActionTime" | ||
|
|
||
| const ScheduleIdleCloseTimeName = "ScheduleIdleCloseTime" |
Contributor
There was a problem hiding this comment.
(nit) imo group these constants
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This adds ScheduleCloseTime, the intent being it helps us identify scheduler problems through automatic scanners
Why?
There's a few cases where it's possible for the scheduler state-machines to transition to invalid states if bugs are present. Looking for the boundary at when we expect schedulers to fire helps us look for these invalid states.
How did you test it?
Potential risks
Should be fairly minimal, as again, this isn't a significant increase in the number of writes to visibility