Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not hold lock when running namespace change callback #3067

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Do not hold lock when running namespace change callback #3067

merged 1 commit into from
Jul 6, 2022

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Jul 6, 2022 •
edited

What changed?

  • Do not hold lock when running namespace change callback

Why?

  • Prevent deadlock in one shard from affecting all other shards on a host and block shard controller.
  • No need to hold the lock anyway when running callback

How did you test it?

Potential risks

Is hotfix candidate?

  • Yes

@yycptt yycptt requested a review from a team as a code owner July 6, 2022 22:05
@yycptt yycptt enabled auto-merge (squash) July 6, 2022 22:13
@yycptt yycptt merged commit 7bb5319 into temporalio:master Jul 6, 2022
@yycptt yycptt deleted the ns-callback-lock branch July 6, 2022 22:30
yycptt added a commit that referenced this pull request Jul 6, 2022
@yycptt
Do not hold lock when running namespace change callback (#3067)
972af2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiminc yiminc yiminc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yycptt @yiminc