Fix sanitize mutable state after replication #3479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
reviewed
Oct 12, 2022
| @@ -849,7 +850,7 @@ func (r *HistoryReplicatorImpl) backfillHistory( | |||
| } | |||
| case *serviceerror.NotFound: | |||
| default: | |||
| return nil, err | |||
| return nil, common.EmptyVersion, err | |||
There was a problem hiding this comment.
I think the value is a "TxnID/TaskID"? Returning a "Version" looks quite confusing to me.
There was a problem hiding this comment.
Update to use a EmptyTaskID
| mutableState.executionInfo.LastFirstEventTxnId = common.EmptyVersion | ||
| mutableState.executionInfo.LastFirstEventTxnId = lastFirstEventTxnID | ||
| mutableState.executionInfo.CloseVisibilityTaskId = common.EmptyVersion | ||
| mutableState.executionInfo.CloseTransferTaskId = common.EmptyVersion |
There was a problem hiding this comment.
Shall we sanitize LastEventTaskId field as well?
There was a problem hiding this comment.
No. This field is to calculate the vector clock. It should not be changed.
yycptt
approved these changes
Oct 13, 2022
Comment on lines
+55
to
+56
| // EmptyTaskID is the id of the empty task | ||
| EmptyTaskID int64 = 0 |
There was a problem hiding this comment.
nit: is this a dup of EmptyEventTaskID defined above?
dnr
pushed a commit
that referenced
this pull request
Oct 17, 2022
* Fix sanitize mutable state after replication
dnr
pushed a commit
that referenced
this pull request
Oct 18, 2022
* Fix sanitize mutable state after replication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fix sanitize mutable state after replication
Why?
How did you test it?
local test
Potential risks
Is hotfix candidate?