Skip to content


Subversion checkout URL

You can clone with
Download ZIP


Parent of Asset not properly set in session #1

wants to merge 1 commit into from

2 participants


in session, the parent isn't being set correctly (actually it's not being set at all) for asset (it should be set to "/themes"). Not sure which other objects aren't being set correctly, but I know this one isn't :)


Seems right :)

Totally missing unit tests to validate the whole API. I'll check in the next few days.

awesome thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 2, 2013
  1. Added /themes as the parent for assets

    Barranger Ridler authored
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +1 −1  lib/session.js
  2. +1 −1  src/
2  lib/session.js
@@ -93,7 +93,7 @@
if (this.valid) {
this.applicationCharge = new ApplicationCharge(;
this.article = new Article(;
- this.asset = new Asset(;
+ this.asset = new Asset('/themes',; = new Blog(;
this.blogMetafield = new Metafield('/blogs',;
this.cart = new Cart(;
2  src/
@@ -57,7 +57,7 @@ class Session
if @valid
@applicationCharge = new ApplicationCharge(@site())
@article = new Article(@site())
- @asset = new Asset(@site())
+ @asset = new Asset('/themes', @site())
@blog = new Blog(@site())
@blogMetafield = new Metafield('/blogs', @site())
@cart = new Cart(@site())
Something went wrong with that request. Please try again.