Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove checkVM_NoFullCloudAccess #1359

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

toshi0607
Copy link

Thank you for the useful product! Based on the GCP documentation, using cloud-platform access scope and IAM is recommended, so the checkVM_NoFullCloudAccess policy is too strict. Please let me remove it.

There are many access scopes available to choose from, but a best practice is to set the cloud-platform access scope, which is an OAuth scope for most Google Cloud services, and then control the service account's access by granting it IAM roles.
https://cloud.google.com/compute/docs/access/service-accounts#scopes_examples

@toshi0607 toshi0607 requested a review from a team as a code owner August 10, 2022 05:38
@gaurav-gogia gaurav-gogia added the policy Issue concerning policy maintainers. label Sep 1, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Merging #1359 (55fe389) into master (313ccf3) will decrease coverage by 0.01%.
The diff coverage is 37.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1359      +/-   ##
==========================================
- Coverage   77.39%   77.38%   -0.02%     
==========================================
  Files         277      277              
  Lines        7813     7817       +4     
==========================================
+ Hits         6047     6049       +2     
- Misses       1406     1407       +1     
- Partials      360      361       +1     
Impacted Files Coverage Δ
...ders/terraform/commons/extract-container-images.go 78.63% <25.00%> (ø)
.../mapper/iac-providers/cft/config/dynamodb-table.go 87.50% <50.00%> (-12.50%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
policy Issue concerning policy maintainers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants