From e5288979230e43d15deafb4960438aee48d996fa Mon Sep 17 00:00:00 2001 From: mikatong Date: Tue, 13 Dec 2022 16:09:04 +0800 Subject: [PATCH 1/2] hpc unit-test support change region --- tencentcloud/provider_test.go | 4 ++++ tencentcloud/resource_tc_cvm_hpc_cluster_test.go | 9 +++++++-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/tencentcloud/provider_test.go b/tencentcloud/provider_test.go index 5986543bc4..d255e331dd 100644 --- a/tencentcloud/provider_test.go +++ b/tencentcloud/provider_test.go @@ -85,6 +85,10 @@ func testAccStepPreConfigSetTempAKSK(t *testing.T, accountType string) { testAccPreCheckCommon(t, accountType) } +func testAccStepSetRegion(t *testing.T, region string) { + os.Setenv(PROVIDER_REGION, region) +} + func testAccPreCheckCommon(t *testing.T, accountType string) { if v := os.Getenv(PROVIDER_REGION); v == "" { log.Printf("[INFO] Testing: Using %s as test region", defaultRegion) diff --git a/tencentcloud/resource_tc_cvm_hpc_cluster_test.go b/tencentcloud/resource_tc_cvm_hpc_cluster_test.go index 5cd33e68a5..27798b77be 100644 --- a/tencentcloud/resource_tc_cvm_hpc_cluster_test.go +++ b/tencentcloud/resource_tc_cvm_hpc_cluster_test.go @@ -15,8 +15,13 @@ func TestAccTencentCloudNeedFixCvmHpcClusterResource_basic(t *testing.T) { Providers: testAccProviders, Steps: []resource.TestStep{ { - Config: testAccCvmHpcCluster, - Check: resource.ComposeTestCheckFunc(resource.TestCheckResourceAttrSet("tencentcloud_cvm_hpc_cluster.hpc_cluster", "id")), + Config: testAccCvmHpcCluster, + PreConfig: func() { testAccStepSetRegion(t, "ap-beijing") }, + Check: resource.ComposeTestCheckFunc( + resource.TestCheckResourceAttrSet("tencentcloud_cvm_hpc_cluster.hpc_cluster", "id"), + resource.TestCheckResourceAttrSet("tencentcloud_cvm_hpc_cluster.hpc_cluster", "name"), + resource.TestCheckResourceAttrSet("tencentcloud_cvm_hpc_cluster.hpc_cluster", "remark"), + ), }, { ResourceName: "tencentcloud_cvm_hpc_cluster.hpc_cluster", From 42812e38c8b3e8f1c543a4c17c787b030eecd44f Mon Sep 17 00:00:00 2001 From: mikatong Date: Tue, 13 Dec 2022 16:22:55 +0800 Subject: [PATCH 2/2] remove needfix flag --- tencentcloud/resource_tc_cvm_hpc_cluster_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tencentcloud/resource_tc_cvm_hpc_cluster_test.go b/tencentcloud/resource_tc_cvm_hpc_cluster_test.go index 27798b77be..448f9efc2d 100644 --- a/tencentcloud/resource_tc_cvm_hpc_cluster_test.go +++ b/tencentcloud/resource_tc_cvm_hpc_cluster_test.go @@ -6,7 +6,7 @@ import ( "github.com/hashicorp/terraform-plugin-sdk/helper/resource" ) -func TestAccTencentCloudNeedFixCvmHpcClusterResource_basic(t *testing.T) { +func TestAccTencentCloudCvmHpcClusterResource_basic(t *testing.T) { t.Parallel() resource.Test(t, resource.TestCase{ PreCheck: func() {