New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

优化 sample.php #72

Merged
merged 2 commits into from Jun 13, 2018

Conversation

Projects
None yet
2 participants
@wi1dcard
Copy link
Contributor

wi1dcard commented Jun 13, 2018

例子太乱,优化一下格式。没有完善就不要放出来,哪怕没有让我们对着 API 手撸也比乱着强。

另外提几个建议:

  • 管理控制台上展示的直接就是 API 域名,为毛 SDK 要给拆开再在内部手动拼接,怎么不做成类似阿里 OSS PHP SDK 的 endPoint 特性
  • guzzle/guzzle 已经 abandon,啥时候更新一波
  • 上传文件流既然 fopen 是外部控制,为何要在内部 close 掉

另外文档写的和 Github 不同步:https://cloud.tencent.com/document/product/436/12266#.E9.85.8D.E7.BD.AE.E6.96.87.E4.BB.B6,这里没有 appId

想起几张图,自己感受下:

image

image

image

@lewzylu

This comment has been minimized.

Copy link
Contributor

lewzylu commented Jun 13, 2018

感谢您的建议。我们这边会改进的

@wi1dcard

This comment has been minimized.

Copy link
Contributor

wi1dcard commented Jun 13, 2018

@lewzylu 没问题的话 merge or close 吧,我这个 pr 只改了例子里一些格式

@wi1dcard

This comment has been minimized.

Copy link
Contributor

wi1dcard commented Jun 13, 2018

@lewzylu btw,这个 sdk 是 python 程序员封装的?看到例子传参之后懵了一下

image

@lewzylu lewzylu merged commit 3219a14 into tencentyun:master Jun 13, 2018

@lewzylu

This comment has been minimized.

Copy link
Contributor

lewzylu commented Jun 13, 2018

@wi1dcard 被发现了,原来主要是搞python的。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment