Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply edits from #46 #47

Merged
merged 1 commit into from Mar 10, 2014
Merged

Conversation

zzak
Copy link
Member

@zzak zzak commented Mar 10, 2014

No description provided.

@zenspider
Copy link
Collaborator

You and @ocha- make a damn fine team.

zenspider added a commit that referenced this pull request Mar 10, 2014
@zenspider zenspider merged commit 67595e3 into ruby:master Mar 10, 2014
--
a - (b - c)
--

When an operator is not allowed to be written in succession like this in the
first place, it is nonassoc.
++ in C language and unary minus are nonassoc.
Note: in the C language "++", "unary" and "minus" are nonassoc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not "unary and minus" but "unary minus."
I think that the "++" operator particularly belongs to the C language in this sentence but "unary minus" is used in a general sense.

Could you fix this?
Or, should I create another pull request for this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocha- Please feel free to submit a patch. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zzak Then I'll take care of this. Probably I'll also edit the "Options" section to be more precise.

I have one thing I'd like to ask your advice.

"Note:" looks like different from my intention,
so if you don't mind I'd like to remove this.

But if something is needed to be natural as English,
I'd like to use "For instance," instead.

How do you think?

I'm sorry that I'm asking this just to improve my English skill.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocha- Let me say, you’ve done a great job translating this documentation!

“For instance,” sounds good.

Feel free to submit any more patches and ping me when you’d like a review :)

On Mar 11, 2014, at 9:27 AM, ocha- notifications@github.com wrote:

In rdoc/en/grammar.en.rdoc:

--
a - (b - c)

When an operator is not allowed to be written in succession like this in the
first place, it is nonassoc.
-++ in C language and unary minus are nonassoc.
+Note: in the C language "++", "unary" and "minus" are nonassoc.
@zzak Then I'll take care of this. Probably I'll also edit the "Options" section to be more precise.

I have one thing I'd like to ask your advice.

"Note:" looks like different from my intention,
so if you don't mind I'd like to remove this.

But if something is needed to be natural as English,
I'd like to use "For instance," instead.

How do you think?

I'm sorry that I'm asking this just to improve my English skill.


Reply to this email directly or view it on GitHub.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zzak You really helped me a lot :) Thanks in advance for the next time.

@zenspider
Copy link
Collaborator

Is there more coming? I want to make sure I keep on top of this.

@ocha-
Copy link
Contributor

ocha- commented Mar 12, 2014

I'd like to rewrite the "Options" section just a little.
It is partially because "allow" is probably not the right word,
and also because only that section was a little ambiguous even in the grammer.ja.rdoc.
For instance, it is written as if result_var option can also be overwritten by command-line but I don't think it's possible.

I actually also want to add some sample grammar files for "no_result_var" and "convert".
But of course, it's up to you whether or not to merge the request.

I'd like to do this one by one and I need to take a little more time to create the next patch.
Sorry for my slow pace.

@zenspider
Copy link
Collaborator

On Mar 12, 2014, at 13:04, ocha- notifications@github.com wrote:

I'd like to rewrite the "Options" section just a little.
It is partially because "allow" is probably not the right word,
and also because only that section was a little ambiguous even in the grammer.ja.rdoc.
For instance, it is written as if result_var option can also be overwritten by command-line but I don't think it's possible.

I actually also want to add some sample grammar files for "no_result_var" and "convert".
But of course, it's up to you whether or not to merge the request.

I'd like to do this one by one and I need to take a little more time to create the next patch.
Sorry for my slow pace.

No apologies necessary. You're doing us a service, not the other way around. Take your time, and thank you for your help.

@zzak zzak deleted the doc_grammar_edits_from_46 branch August 9, 2016 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants