Ensure test compatibility with Rails 3.2.x/4.0.x/4.1.x #44

merged 3 commits into from Jun 8, 2014


None yet
2 participants

tardate commented Apr 17, 2014

As I started looking into (some other) bug, I first found I couldn't run the tests because of some recent Rails internals restructuring.

A couple of commits here that get me back to the point where I get green tests on Rails 3.2.x, 4.0.x and 4.1.x

NB: I pulled in #40 as part of the pull request

ktdreyer and others added some commits Nov 7, 2013

require timeout in tests
When running "testrb test/test_rails_autolink.rb", the test suite fails:

  NameError: uninitialized constant TestRailsAutolink::Timeout

Explicitly load the timeout gem during the tests to fix this error.
refactor Gemfile/tests to revive ability to run against Rails 3.2.x, …
…4.0.x, 4.1.x

* simplify required modules for tests to avoid version-specific breakage because of internal Rails refactoring
* Gemfile has notes on dependencies - it's not automatic
* mintiest pegged down for Rails 3.2.x to avoid assert_dom_equal issue
* if rails_autolink/helpers included before action_view/helpers, it was obscuring helper methods

@tardate tardate merged commit 5e25346 into tenderlove:master Jun 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment