Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Correct markup of commiter data

  • Loading branch information...
commit 7912fb39c6c35b997059711b40a281b325f528e3 1 parent 6599a02
@kossnocorp kossnocorp authored
Showing with 46 additions and 48 deletions.
  1. +3 −1 app/stylesheets/master.sass
  2. +43 −47 app/views/accounts/_account.html.erb
View
4 app/stylesheets/master.sass
@@ -58,4 +58,6 @@ table.commiters
.commiter-data
padding-left: 95px
- //float: left
+
+dl
+ margin-bottom: 10px
View
90 app/views/accounts/_account.html.erb
@@ -10,6 +10,7 @@
</ul>
<div class="commiter-data">
+
<h2><%= account.username %></h2>
<% if account.names.length > 0 %>
@@ -18,56 +19,51 @@
</h3>
<% end %>
- <table>
- <% if account.nicks.length > 0 %>
- <tr>
- <td>Nicknames:</td>
- <td>
- <ul>
- <%= render :partial => 'name', :collection => account.nicks %>
- </ul>
- </td>
- </tr>
- <% end %>
+ <% if account.nicks.length > 0 %>
+ <dl class="nicknames">
+ <dt>Nicknames:</dt>
+ <dl><%= account.nicks.map(&:value).join(', ') %></dl>
+ </dl>
+ <% end %>
+
+ <% if account.sites.length > 0 %>
+ <dl class="sites">
+ <dt>Sites:</dt>
+ <dl>
+ <ul>
+ <%= render :partial => 'site', :collection => account.sites %>
+ </ul>
+ </dl>
+ </dl>
+ <% end %>
- <% if account.sites.length > 0 %>
- <tr>
- <td>Sites:</td>
- <td>
- <ul>
- <%= render :partial => 'site', :collection => account.sites %>
- </ul>
- </td>
- </tr>
- <% end %>
+ <% if account.services.length > 0 %>
+ <dl class="services">
+ <dt>Services:</dt>
+ <dl>
+ <ul>
+ <%= render :partial => 'service', :collection => account.services %>
+ </ul>
+ </dl>
+ </dl>
+ <% end %>
- <% if account.services.length > 0 %>
- <tr>
- <td>Services:</td>
- <td>
- <ul>
- <%= render :partial => 'service', :collection => account.services %>
- </ul>
- </td>
- </tr>
- <% end %>
+ <!-- FIXME: unsure how to link to ISBN. :-( -->
+ <!--
+ <% if account.books.length > 0 %>
+ <tr>
+ <td>Books:</td>
+ <td>
+ <ul>
+ <% account.books.each do |book| %>
+ <li><%= book.key %></li>
+ <% end %>
+ </ul>
+ </td>
+ </tr>
+ <% end %>
+ -->
- <!-- FIXME: unsure how to link to ISBN. :-( -->
- <!--
- <% if account.books.length > 0 %>
- <tr>
- <td>Books:</td>
- <td>
- <ul>
- <% account.books.each do |book| %>
- <li><%= book.key %></li>
- <% end %>
- </ul>
- </td>
- </tr>
- <% end %>
- -->
- </table>
</div>
</div>
</td>
Please sign in to comment.
Something went wrong with that request. Please try again.