Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Better design #14

Closed
wants to merge 1 commit into from

2 participants

Shota Fukumori Aaron Patterson
Shota Fukumori
Collaborator

Better design...

Aaron Patterson
Owner

Thanks sora! I've merted

Aaron Patterson
Owner

oops, 間違いました。他のpull requestをmergeしました

Aaron Patterson tenderlove closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 12, 2011
  1. Shota Fukumori

    Better design

    sorah authored
This page is out of date. Refresh to see the latest.
14 app/views/accounts/_account.html.erb
View
@@ -1,13 +1,13 @@
<li>
<table>
<tr>
- <td>Account:</td>
+ <th>Account:</th>
<td><%= account.username %></td>
</tr>
<% unless account.names.empty? %>
<tr>
- <td>Names:</td>
+ <th>Names:</th>
<td>
<ul>
<%= render :partial => 'name', :collection => account.names %>
@@ -18,7 +18,7 @@
<% unless account.nicks.empty? %>
<tr>
- <td>Nicknames:</td>
+ <th>Nicknames:</th>
<td>
<ul>
<%= render :partial => 'name', :collection => account.nicks %>
@@ -29,7 +29,7 @@
<% unless account.sites.empty? %>
<tr>
- <td>Sites:</td>
+ <th>Sites:</th>
<td>
<ul>
<%= render :partial => 'site', :collection => account.sites %>
@@ -40,7 +40,7 @@
<% unless account.services.empty? %>
<tr>
- <td>Services:</td>
+ <th>Services:</th>
<td>
<ul>
<%= render :partial => 'service', :collection => account.services %>
@@ -51,7 +51,7 @@
<% unless account.portraits.empty? %>
<tr>
- <td>Portraits:</td>
+ <th>Portraits:</th>
<td>
<ul>
<%= render :partial => 'portrait', :collection => account.portraits %>
@@ -64,7 +64,7 @@
<!--
<% unless account.books.empty? %>
<tr>
- <td>Books:</td>
+ <th>Books:</th>
<td>
<ul>
<% account.books.each do |book| %>
2  app/views/accounts/index.html.erb
View
@@ -1,5 +1,5 @@
<h1>Ruby Committers</h1>
<%= link_to 'fork me on github', 'http://github.com/tenderlove/rubycommitters.org' %>
-<ul>
+<ul class="committers">
<%= render :partial => 'account', :collection => @accounts %>
</ul>
22 public/stylesheets/site.css
View
@@ -5,3 +5,25 @@
.image-wrapper img {
height: 100%;
}
+
+ul.committers {
+ list-style-type: none;
+ padding-left: 0px;
+}
+
+ul.committers li{
+ margin-bottom: 5px;
+}
+
+ul.committers li table{
+ padding: 2px;
+ border-collapse: separate;
+ width: 500px;
+}
+
+ul.committers li th{
+ background-color: #EEE;
+ text-align: left;
+ padding: 3px;
+ width: 80px;
+}
Something went wrong with that request. Please try again.