Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NewLegacyKeccak512 hash function #1

Merged
merged 1 commit into from Aug 23, 2019
Merged

Conversation

@musnit
Copy link

musnit commented May 31, 2019

Go-Ethereum uses the NewLegacyKeccak512 from an newer version of golang/crypto.

This function is being added here to allow for compatibility with Go-Ethereum and Cosmos-SDK.

Code taken from: https://github.com/golang/crypto/blob/master/sha3/hashes.go#L61-L65

Go-Ethereum uses the NewLegacyKeccak512 from an newer version of golang/crypto.

This function is being added here to allow for compatibility with Go-Ethereum and Cosmos-SDK
@kivey87

This comment has been minimized.

Copy link

kivey87 commented Jun 27, 2019

Bumping this PR - you cannot build a Cosmos SDK app in a vgo project that also imports go-ethereum.

@ackratos

This comment has been minimized.

Copy link

ackratos commented Jul 6, 2019

we also want this to be merged

@jkilpatr

This comment has been minimized.

Copy link

jkilpatr commented Aug 23, 2019

bumping this again

@ebuchman ebuchman merged commit 45b1026 into tendermint:master Aug 23, 2019
@ackratos

This comment has been minimized.

Copy link

ackratos commented Aug 26, 2019

@ebuchman thank you for merging this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.