Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is Signed PreCommit:(none) safe? #321

Closed
mdyring opened this issue Jul 28, 2019 · 4 comments

Comments

@mdyring
Copy link
Contributor

commented Jul 28, 2019

Below is the initial log from starting up tmkms against 5 validators. Decided for full log to illustrate it happens very early where some validators have yet to connect.

I am worried about the signed PreCommit:(none) lines since it is occurring at same height 82953 for which a Proposal was signed earlier (block id DE23ECA605). Can this safely be ignored?

tmkms[3137]: 09:29:24 [info] tmkms 0.6.0-rc1 starting up...
tmkms[3137]: 09:29:24 [info] [keyring:softsign] added consensus key cosmosvalconspub1zcjduepqyvkueggjf7n0drgw8yx286t9tkklvznmtnj46utxwr478d8clf4sfvsa3c
tmkms[3137]: 09:29:24 [info] KMS node ID: 20E2B9BE81DD6CBB410B14FB59EBD4DBC9E0228C
tmkms[3137]: 09:29:24 [info] KMS node ID: 20E2B9BE81DD6CBB410B14FB59EBD4DBC9E0228C
tmkms[3137]: 09:29:24 [info] KMS node ID: 20E2B9BE81DD6CBB410B14FB59EBD4DBC9E0228C
tmkms[3137]: 09:29:24 [warn] [gaia-13004] 54.93.169.244:26659: unverified validator peer ID! (816C4117DAD41E6E44546AE1B679939506A53573)
tmkms[3137]: 09:29:24 [info] [gaia-13004@tcp://54.93.169.244:26659] connected to validator successfully
tmkms[3137]: 09:29:24 [warn] [gaia-13004] 35.156.81.246:26659: unverified validator peer ID! (FE9E6BF8A24151B5422728AFDACF2E0DDE479769)
tmkms[3137]: 09:29:24 [info] [gaia-13004@tcp://35.156.81.246:26659] connected to validator successfully
tmkms[3137]: 09:29:24 [warn] [gaia-13004] 35.158.126.240:26659: unverified validator peer ID! (ADCA89A67DAA5FFC2D2EFFD8AD33B1DC8DCD9466)
tmkms[3137]: 09:29:24 [info] [gaia-13004@tcp://35.158.126.240:26659] connected to validator successfully
tmkms[3137]: 09:29:24 [warn] [gaia-13004] 18.196.17.223:26659: unverified validator peer ID! (020C63DD6718416C1D4670D398F6073389CA0C93)
tmkms[3137]: 09:29:24 [info] [gaia-13004@tcp://18.196.17.223:26659] connected to validator successfully
tmkms[3137]: 09:29:24 [warn] [gaia-13004] 18.196.63.108:26659: unverified validator peer ID! (00ACD9BDBE36B2933231545AEBF1D799DD06D83B)
tmkms[3137]: 09:29:24 [info] [gaia-13004@tcp://18.196.63.108:26659] connected to validator successfully
tmkms[3137]: 09:29:24 [info] [gaia-13004@35.158.126.240:26659] signed PreVote:(none) at h/r/s 82952/0/6 (0 ms)
tmkms[3137]: 09:29:24 [info] [gaia-13004@54.93.169.244:26659] signed PreVote:174F673251 at h/r/s 82952/0/6 (0 ms)
tmkms[3137]: 09:29:24 [info] [gaia-13004@35.156.81.246:26659] signed PreVote:174F673251 at h/r/s 82952/0/6 (0 ms)
tmkms[3137]: 09:29:24 [info] [gaia-13004@18.196.17.223:26659] signed PreVote:(none) at h/r/s 82952/0/6 (0 ms)
tmkms[3137]: 09:29:24 [info] [gaia-13004@18.196.63.108:26659] signed PreVote:174F673251 at h/r/s 82952/0/6 (0 ms)
tmkms[3137]: 09:29:24 [info] [gaia-13004@35.158.126.240:26659] signed PreCommit:174F673251 at h/r/s 82952/0/6 (0 ms)
tmkms[3137]: 09:29:24 [info] [gaia-13004@18.196.17.223:26659] signed PreCommit:174F673251 at h/r/s 82952/0/6 (0 ms)
tmkms[3137]: 09:29:24 [info] [gaia-13004@35.156.81.246:26659] signed PreCommit:174F673251 at h/r/s 82952/0/6 (0 ms)
tmkms[3137]: 09:29:24 [info] [gaia-13004@54.93.169.244:26659] signed PreCommit:174F673251 at h/r/s 82952/0/6 (0 ms)
tmkms[3137]: 09:29:24 [info] [gaia-13004@18.196.63.108:26659] signed PreCommit:174F673251 at h/r/s 82952/0/6 (0 ms)
tmkms[3137]: 09:29:25 [info] [gaia-13004@35.156.81.246:26659] signed Proposal:DE23ECA605 at h/r/s 82953/0/3 (0 ms)
tmkms[3137]: 09:29:25 [warn] [gaia-13004:18.196.63.108:26659] attempt to double sign at h/r/s: 82953/0/3 (DE23ECA605 != AEFFF4498D)
tmkms[3137]: 09:29:25 [warn] [gaia-13004:35.158.126.240:26659] attempt to double sign at h/r/s: 82953/0/3 (DE23ECA605 != 1B867E0652)
tmkms[3137]: 09:29:25 [info] [gaia-13004@35.156.81.246:26659] signed PreCommit:(none) at h/r/s 82953/0/6 (0 ms)
tmkms[3137]: 09:29:25 [info] [gaia-13004@18.196.63.108:26659] signed PreCommit:(none) at h/r/s 82953/0/6 (0 ms)
tmkms[3137]: 09:29:25 [info] [gaia-13004@35.158.126.240:26659] signed PreCommit:(none) at h/r/s 82953/0/6 (0 ms)
tmkms[3137]: 09:29:25 [error] [gaia-13004@tcp://54.93.169.244:26659] attempted double sign: step regression: round regression at height:82953 round:0 last step:6 new step:3
tmkms[3137]: 09:29:25 [error] [gaia-13004@tcp://18.196.17.223:26659] attempted double sign: step regression: round regression at height:82953 round:0 last step:6 new step:3
tmkms[3137]: 09:29:26 [info] KMS node ID: 20E2B9BE81DD6CBB410B14FB59EBD4DBC9E0228C
tmkms[3137]: 09:29:26 [info] KMS node ID: 20E2B9BE81DD6CBB410B14FB59EBD4DBC9E0228C
tmkms[3137]: 09:29:26 [warn] [gaia-13004] 54.93.169.244:26659: unverified validator peer ID! (816C4117DAD41E6E44546AE1B679939506A53573)
tmkms[3137]: 09:29:26 [info] [gaia-13004@tcp://54.93.169.244:26659] connected to validator successfully
tmkms[3137]: 09:29:26 [info] [gaia-13004@35.156.81.246:26659] signed PreVote:341960D025 at h/r/s 82953/1/6 (0 ms)
tmkms[3137]: 09:29:26 [info] [gaia-13004@18.196.63.108:26659] signed PreVote:341960D025 at h/r/s 82953/1/6 (0 ms)
tmkms[3137]: 09:29:26 [info] [gaia-13004@35.158.126.240:26659] signed PreVote:341960D025 at h/r/s 82953/1/6 (0 ms)
tmkms[3137]: 09:29:26 [info] [gaia-13004@54.93.169.244:26659] signed PreVote:341960D025 at h/r/s 82953/1/6 (0 ms)
tmkms[3137]: 09:29:26 [info] [gaia-13004@54.93.169.244:26659] signed PreCommit:341960D025 at h/r/s 82953/1/6 (0 ms)
tmkms[3137]: 09:29:26 [info] [gaia-13004@35.156.81.246:26659] signed PreCommit:341960D025 at h/r/s 82953/1/6 (0 ms)
tmkms[3137]: 09:29:26 [info] [gaia-13004@35.158.126.240:26659] signed PreCommit:341960D025 at h/r/s 82953/1/6 (0 ms)
tmkms[3137]: 09:29:26 [info] [gaia-13004@18.196.63.108:26659] signed PreCommit:341960D025 at h/r/s 82953/1/6 (0 ms)
tmkms[3137]: 09:29:27 [warn] [gaia-13004] 18.196.17.223:26659: unverified validator peer ID! (020C63DD6718416C1D4670D398F6073389CA0C93)
tmkms[3137]: 09:29:27 [info] [gaia-13004@tcp://18.196.17.223:26659] connected to validator successfully
tmkms[3137]: 09:29:32 [info] [gaia-13004@18.196.63.108:26659] signed PreVote:592D451F00 at h/r/s 82954/0/6 (0 ms)
tmkms[3137]: 09:29:32 [info] [gaia-13004@18.196.17.223:26659] signed PreVote:592D451F00 at h/r/s 82954/0/6 (0 ms)
tmkms[3137]: 09:29:32 [info] [gaia-13004@54.93.169.244:26659] signed PreVote:592D451F00 at h/r/s 82954/0/6 (0 ms)
tmkms[3137]: 09:29:32 [info] [gaia-13004@35.156.81.246:26659] signed PreVote:592D451F00 at h/r/s 82954/0/6 (0 ms)
tmkms[3137]: 09:29:32 [info] [gaia-13004@35.158.126.240:26659] signed PreVote:592D451F00 at h/r/s 82954/0/6 (0 ms)
@zmanian

This comment has been minimized.

Copy link
Collaborator

commented Jul 28, 2019

There are many cases where a correct node will vote nil in the Tendermint consensus algorithm.

Search for nil in the document.
https://tendermint.com/docs/spec/consensus/consensus.html#byzantine-consensus-algorithm

@tarcieri tarcieri closed this Jul 28, 2019

@mdyring

This comment has been minimized.

Copy link
Contributor Author

commented Jul 29, 2019

Thanks for clarifying. Better safe than sorry. ;-)

@mdyring

This comment has been minimized.

Copy link
Contributor Author

commented Aug 3, 2019

Related to #333 - not sure if that is on latest version though or if that makes a difference, but I see the log has a different format (ESC character at start of log).

@tarcieri

This comment has been minimized.

Copy link
Collaborator

commented Aug 3, 2019

@mdyring #333 looks like a real bug.

The escape sequences in the logs are from from ANSI colors, which are enabled when the TERM variable is set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.