Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panicked at called Result::unwrap() on an `Err` value #341

Closed
mdyring opened this issue Aug 7, 2019 · 2 comments

Comments

@mdyring
Copy link
Contributor

commented Aug 7, 2019

On v0.6.1 with 5 validators connected to gaia-13004.

Have not been able to reproduce it after tmkms restart :-/

Aug 07 10:28:36 kms2 tmkms[20220]: 08:28:36 [info] [gaia-13004@tcp://18.184.6.56:26659] connected to validator successfully
Aug 07 10:28:36 kms2 tmkms[20220]: 08:28:36 [warn] [gaia-13004] tcp://18.184.6.56:26659: unverified validator peer ID! (9680A513535A0E8B552E6154374374B5A5756644)
Aug 07 10:28:36 kms2 tmkms[20220]: 08:28:36 [info] KMS node ID: 20E2B9BE81DD6CBB410B14FB59EBD4DBC9E0228C
Aug 07 10:28:36 kms2 tmkms[20220]: thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "PoisonError { inner: .. }"', src/libcore/result.rs:997:5
Aug 07 10:28:36 kms2 tmkms[20220]: stack backtrace:
Aug 07 10:28:36 kms2 tmkms[20220]:    0:     0x55d45a6205c3 - std::sys::unix::backtrace::tracing::imp::unwind_backtrace::hd71462e61ec5c76e
Aug 07 10:28:36 kms2 tmkms[20220]:                                at src/libstd/sys/unix/backtrace/tracing/gcc_s.rs:39
Aug 07 10:28:36 kms2 tmkms[20220]:    1:     0x55d45a61b66b - std::sys_common::backtrace::_print::hae2106692f421f30
Aug 07 10:28:36 kms2 tmkms[20220]:                                at src/libstd/sys_common/backtrace.rs:70
Aug 07 10:28:36 kms2 tmkms[20220]:    2:     0x55d45a61e746 - std::panicking::default_hook::{{closure}}::h4e372307f318ae92
Aug 07 10:28:36 kms2 tmkms[20220]:                                at src/libstd/sys_common/backtrace.rs:58
Aug 07 10:28:36 kms2 tmkms[20220]:                                at src/libstd/panicking.rs:200
Aug 07 10:28:36 kms2 tmkms[20220]:    3:     0x55d45a61e4c4 - std::panicking::default_hook::hb6f777c87029e950
Aug 07 10:28:36 kms2 tmkms[20220]:                                at src/libstd/panicking.rs:215
Aug 07 10:28:36 kms2 tmkms[20220]:    4:     0x55d45a61ee4f - std::panicking::rust_panic_with_hook::h49d43efebcb63d45
Aug 07 10:28:36 kms2 tmkms[20220]:                                at src/libstd/panicking.rs:478
Aug 07 10:28:36 kms2 tmkms[20220]:    5:     0x55d45a61e9d1 - std::panicking::continue_panic_fmt::h87cb4de2c26b0fa7
Aug 07 10:28:36 kms2 tmkms[20220]:                                at src/libstd/panicking.rs:385
Aug 07 10:28:36 kms2 tmkms[20220]:    6:     0x55d45a61e8b5 - rust_begin_unwind
Aug 07 10:28:36 kms2 tmkms[20220]:                                at src/libstd/panicking.rs:312
Aug 07 10:28:36 kms2 tmkms[20220]:    7:     0x55d45a63cb9c - core::panicking::panic_fmt::h472d766e4dff71a2
Aug 07 10:28:36 kms2 tmkms[20220]:                                at src/libcore/panicking.rs:85
Aug 07 10:28:36 kms2 tmkms[20220]:    8:     0x55d45a4c3153 - core::result::unwrap_failed::h5df41bfe46c65634
Aug 07 10:28:36 kms2 tmkms[20220]:    9:     0x55d45a535a5a - tmkms::session::Session::handle_request::h7f470c1d3320cbf7
Aug 07 10:28:36 kms2 tmkms[20220]:   10:     0x55d45a4bf42a - std::panicking::try::do_call::h95c8bc43231b75c6
Aug 07 10:28:36 kms2 tmkms[20220]:   11:     0x55d45a628d19 - __rust_maybe_catch_panic
Aug 07 10:28:36 kms2 tmkms[20220]:                                at src/libpanic_unwind/lib.rs:87
Aug 07 10:28:36 kms2 tmkms[20220]:   12:     0x55d45a4cadf8 - tmkms::client::connect::hf7ee2bbe1886c2ce
Aug 07 10:28:36 kms2 tmkms[20220]:   13:     0x55d45a4cab3b - tmkms::client::main_loop::h10b955c3e3468fe3
Aug 07 10:28:36 kms2 tmkms[20220]:   14:     0x55d45a4e3e63 - std::sys_common::backtrace::__rust_begin_short_backtrace::h3b57df20918568e8
Aug 07 10:28:36 kms2 tmkms[20220]:   15:     0x55d45a4bf573 - std::panicking::try::do_call::hc308b666ba256d3f
Aug 07 10:28:36 kms2 tmkms[20220]:   16:     0x55d45a628d19 - __rust_maybe_catch_panic
Aug 07 10:28:36 kms2 tmkms[20220]:                                at src/libpanic_unwind/lib.rs:87
Aug 07 10:28:36 kms2 tmkms[20220]:   17:     0x55d45a4c3bb7 - <F as alloc::boxed::FnBox<A>>::call_box::h2148cdda0d1d31a1
Aug 07 10:28:36 kms2 tmkms[20220]:   18:     0x55d45a6283cd - std::sys::unix::thread::Thread::new::thread_start::hb4e0e015a1494c74
Aug 07 10:28:36 kms2 tmkms[20220]:                                at /rustc/91856ed52c58aa5ba66a015354d1cc69e9779bdf/src/liballoc/boxed.rs:759
Aug 07 10:28:36 kms2 tmkms[20220]:                                at src/libstd/sys_common/thread.rs:14
Aug 07 10:28:36 kms2 tmkms[20220]:                                at src/libstd/sys/unix/thread.rs:81
Aug 07 10:28:36 kms2 tmkms[20220]:   19:     0x7f39aec1b4a3 - start_thread
Aug 07 10:28:36 kms2 tmkms[20220]:   20:     0x7f39ae746d0e - __clone
Aug 07 10:28:36 kms2 tmkms[20220]:   21:                0x0 - <unknown>
Aug 07 10:28:36 kms2 tmkms[20220]: 08:28:36 [error] [gaia-13004@tcp://18.184.6.56:26659] internal crash: unknown cause
Aug 07 10:28:36 kms2 tmkms[20220]: 08:28:36 [info] [gaia-13004@tcp://3.123.0.185:26659] connected to validator successfully
@westaking

This comment has been minimized.

Copy link

commented Aug 7, 2019

#340 same issue.
this error occurs after signed PreVote:< nil >

@tarcieri

This comment has been minimized.

Copy link
Collaborator

commented Aug 7, 2019

PR to fix the crash on the error message here: https://github.com/tendermint/kms/pull/342/files

@tarcieri tarcieri closed this in 202e1d6 Aug 7, 2019

tarcieri pushed a commit that referenced this issue Aug 7, 2019

chain/state: Add tests for `<nil>` block ID transitions
I've confirmed these would've caught the crashes encountered in
issues #340/#341:

    test chain::state::tests::hrs_test_nil_block_id_double_sign ... FAILED

    failures:

    ---- chain::state::tests::hrs_test_nil_block_id_double_sign stdout ----
    thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', src/libcore/option.rs:347:21
    note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

    failures:
        chain::state::tests::hrs_test_nil_block_id_double_sign

    test result: FAILED. 7 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out

tarcieri pushed a commit that referenced this issue Aug 7, 2019

chain/state: Add tests for `<nil>` block ID transitions
I've confirmed these would've caught the crashes encountered in
issues #340/#341:

    test chain::state::tests::hrs_test_nil_block_id_double_sign ... FAILED

    failures:

    ---- chain::state::tests::hrs_test_nil_block_id_double_sign stdout ----
    thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', src/libcore/option.rs:347:21
    note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

    failures:
        chain::state::tests::hrs_test_nil_block_id_double_sign

    test result: FAILED. 7 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.