Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serde(deny_unknown_fields) to all config structs #282

Merged
merged 1 commit into from Jun 25, 2019

Conversation

@tarcieri
Copy link
Collaborator

commented Jun 25, 2019

By default serde ignores unknown fields. This is nice for RPC, but less so for configuration files.

This annotates every config struct with serde(deny_unknown_fields) so as to catch things like spelling mistakes or keys that are in the wrong location.

Add serde(deny_unknown_fields) to all config structs
By default serde ignores unknown fields. This is nice for RPC, but less
so for configuration files.

This annotates every config struct with `serde(deny_unknown_fields)` so
as to catch things like spelling mistakes or keys that are in the wrong
location.

@tarcieri tarcieri merged commit e018363 into master Jun 25, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tarcieri tarcieri deleted the deny-unknown-config-fields branch Jun 25, 2019

@tarcieri tarcieri referenced this pull request Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.