Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect and don't attempt to recover from PoisonError #345

Merged
merged 1 commit into from Aug 7, 2019

Conversation

@tony-iqlusion
Copy link
Contributor

commented Aug 7, 2019

PoisonError indicates that a mutex-guarded data structure is in an inconsistent state because a panic occurred while the mutex was held.

We can't recover from these, so detect when they happen and exit afterward.

Additionally this names each client thread to ease debugging, and adds some better debug logging in several places.

Detect and don't attempt to recover from PoisonError
PoisonError indicates that a mutex-guarded data structure is in an
inconsistent state because a panic occurred while the mutex was held.

We can't recover from these, so detect when they happen and exit
afterward.

Additionally this names each client thread to ease debugging, and adds
some better debug logging in several places.

@tarcieri tarcieri merged commit 30c2ae3 into master Aug 7, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tarcieri tarcieri deleted the exit-on-poison-error branch Aug 7, 2019

@tony-iqlusion tony-iqlusion referenced this pull request Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.