New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HOTFIX: AddressBook requires addresses to have IDs; Do not close conn immediately after sending pex addrs in seed mode #2797
Conversation
bddeef4
to
14e4d97
Compare
14e4d97
to
58574b7
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2797 +/- ##
===========================================
- Coverage 62.3% 62.23% -0.07%
===========================================
Files 212 212
Lines 17210 17225 +15
===========================================
- Hits 10722 10720 -2
- Misses 5588 5603 +15
- Partials 900 902 +2
|
Looks like a lot of commits are from the current |
Thanks. Retargeted to develop. Will merge and release v0.26.1. I took a stab at flushing messages on the conn before stopping in #2802 - should address https://github.com/tendermint/tendermint/pull/2797/files#diff-8c6b1a350a161ced01d68514ccda7484R224 |
p2p/pex/pex_reactor.go
Outdated
@@ -221,6 +221,7 @@ func (r *PEXReactor) Receive(chID byte, src Peer, msgBytes []byte) { | |||
// 2) limit the output size | |||
if r.config.SeedMode { | |||
r.SendAddrs(src, r.book.GetSelectionWithBias(biasToSelectNewPeers)) | |||
time.Sleep(time.Second * 3) // TODO Rethink this. Without it, above may not actually send. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should put these in a go-routine so as to not block Receive
- [p2p] [\#2668](https://github.com/tendermint/tendermint/issues/2668) Reconnect to originally dialed address (not self-reported | ||
address) for persistent peers | ||
- [p2p] [\#2668](https://github.com/tendermint/tendermint/issues/2668) Reconnect to originally dialed address (not self-reported address) for persistent peers | ||
- [p2p] [\#2797](https://github.com/tendermint/tendermint/pull/2797) AddressBook requires addresses to have IDs; Do not crap out immediately after sending pex addrs in seed mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong changelog file :o ! Please use CHANGELOG_PENDING.md
* 'master' of https://github.com/tendermint/tendermint: (330 commits) Release/v0.26.1 (tendermint#2803) fix amino overhead computation for Tx (tendermint#2792) p2p: re-check after sleeps (tendermint#2664) check the result of `ps.peer.Send` before calling `ps.setHasVote` (tendermint#2787) p2p: AddressBook requires addresses to have IDs; Do not close conn immediately after sending pex addrs in seed mode (tendermint#2797) test AutoFile#Size (happy path) [autofile/group] do not panic when checking size openFile creates a file if not exist => ErrNotExist is not possible use our logger in autofile/group Add tests for ValidateBasic methods (tendermint#2754) [docs] improve organization of ABCI docs & fix links (tendermint#2749) p2p: peer-id -> peer_id (tendermint#2771) mempool: print postCheck error (tendermint#2762) Fix crypto/merkle ProofOperators.Verify to check bounds on keypath pa… (tendermint#2756) Mempool WAL is still created by default in home directory, leads to permission errors (tendermint#2758) mempool: ErrPreCheck and more log info (tendermint#2724) Release/v0.26.0 (tendermint#2726) [ADR] [DRAFT] pubsub 2.0 (tendermint#2532) validate reactor messages (tendermint#2711) TMHASH is 32 bytes. Closes tendermint#1990 (tendermint#2732) ...
This solves an issue of having peers without IDs in the address book.
It also fixes #2773, which was a likely cause of there being peers without IDs in the address book in the first place.
It also includes a temporary hack fix for #2092.