HOTFIX: AddressBook requires addresses to have IDs; Do not close conn immediately after sending pex addrs in seed mode #2797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaekwon
requested review from
ebuchman,
melekes,
xla and
zramsay
as code owners
jaekwon
force-pushed
the
jae/addr_noid
branch
from
bddeef4
to
14e4d97
Compare
jaekwon
force-pushed
the
jae/addr_noid
branch
from
14e4d97
to
58574b7
Compare
Closed
Codecov Report
@@ Coverage Diff @@
## develop #2797 +/- ##
===========================================
- Coverage 62.3% 62.23% -0.07%
===========================================
Files 212 212
Lines 17210 17225 +15
===========================================
- Hits 10722 10720 -2
- Misses 5588 5603 +15
- Partials 900 902 +2
|
jaekwon
changed the title
jaekwon
changed the title
|
Looks like a lot of commits are from the current |
|
Thanks. Retargeted to develop. Will merge and release v0.26.1. I took a stab at flushing messages on the conn before stopping in #2802 - should address https://github.com/tendermint/tendermint/pull/2797/files#diff-8c6b1a350a161ced01d68514ccda7484R224 |
ebuchman
approved these changes
Nov 11, 2018
p2p/pex/pex_reactor.go
Outdated
| @@ -221,6 +221,7 @@ func (r *PEXReactor) Receive(chID byte, src Peer, msgBytes []byte) { | |||
| // 2) limit the output size | |||
| if r.config.SeedMode { | |||
| r.SendAddrs(src, r.book.GetSelectionWithBias(biasToSelectNewPeers)) | |||
| time.Sleep(time.Second * 3) // TODO Rethink this. Without it, above may not actually send. | |||
There was a problem hiding this comment.
We should put these in a go-routine so as to not block Receive
ebuchman
changed the title
ebuchman
reviewed
Nov 11, 2018
| - [p2p] [\#2668](https://github.com/tendermint/tendermint/issues/2668) Reconnect to originally dialed address (not self-reported | ||
| address) for persistent peers | ||
| - [p2p] [\#2668](https://github.com/tendermint/tendermint/issues/2668) Reconnect to originally dialed address (not self-reported address) for persistent peers | ||
| - [p2p] [\#2797](https://github.com/tendermint/tendermint/pull/2797) AddressBook requires addresses to have IDs; Do not crap out immediately after sending pex addrs in seed mode |
There was a problem hiding this comment.
Wrong changelog file :o ! Please use CHANGELOG_PENDING.md
maxim-levy
pushed a commit
to maxim-levy/tendermint
that referenced
this pull request
Nov 13, 2018
* 'master' of https://github.com/tendermint/tendermint: (330 commits) Release/v0.26.1 (tendermint#2803) fix amino overhead computation for Tx (tendermint#2792) p2p: re-check after sleeps (tendermint#2664) check the result of `ps.peer.Send` before calling `ps.setHasVote` (tendermint#2787) p2p: AddressBook requires addresses to have IDs; Do not close conn immediately after sending pex addrs in seed mode (tendermint#2797) test AutoFile#Size (happy path) [autofile/group] do not panic when checking size openFile creates a file if not exist => ErrNotExist is not possible use our logger in autofile/group Add tests for ValidateBasic methods (tendermint#2754) [docs] improve organization of ABCI docs & fix links (tendermint#2749) p2p: peer-id -> peer_id (tendermint#2771) mempool: print postCheck error (tendermint#2762) Fix crypto/merkle ProofOperators.Verify to check bounds on keypath pa… (tendermint#2756) Mempool WAL is still created by default in home directory, leads to permission errors (tendermint#2758) mempool: ErrPreCheck and more log info (tendermint#2724) Release/v0.26.0 (tendermint#2726) [ADR] [DRAFT] pubsub 2.0 (tendermint#2532) validate reactor messages (tendermint#2711) TMHASH is 32 bytes. Closes tendermint#1990 (tendermint#2732) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves an issue of having peers without IDs in the address book.
It also fixes #2773, which was a likely cause of there being peers without IDs in the address book in the first place.
It also includes a temporary hack fix for #2092.